Skip to content

werft/deploy/post-process: Remove openvsx statefulsetstatus #8532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 2, 2022

Conversation

ArthurSens
Copy link
Contributor

@ArthurSens ArthurSens commented Mar 2, 2022

Signed-off-by: ArthurSens [email protected]

Description

While #8529 is not fixed, we're adding a workaround to remove the status field from OpenVSX-Proxy statefulset, to make sure our deployment works on both core-dev and harvester.

Related Issue(s)

Fixes #

How to test

Start a preview on core-dev and harvester

Docs change tested with https://www.yamldiff.com/

Release Notes

NONE

@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #8532 (b2a6a00) into main (61b50e7) will increase coverage by 2.79%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            main    #8532      +/-   ##
=========================================
+ Coverage   8.37%   11.17%   +2.79%     
=========================================
  Files         33       18      -15     
  Lines       2339      993    -1346     
=========================================
- Hits         196      111      -85     
+ Misses      2138      880    -1258     
+ Partials       5        2       -3     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
install-installer-raw-app ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
install/installer/pkg/common/storage.go
...installer/pkg/components/ws-manager/rolebinding.go
install/installer/pkg/common/render.go
...staller/pkg/components/ws-manager/networkpolicy.go
install/installer/pkg/common/objects.go
...nstall/installer/pkg/components/ws-manager/role.go
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go
install/installer/pkg/common/common.go
.../installer/pkg/components/ws-manager/deployment.go
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61b50e7...b2a6a00. Read the comment docs.

@ArthurSens ArthurSens requested a review from a team March 2, 2022 11:30
@roboquat roboquat added size/S and removed size/XS labels Mar 2, 2022
@github-actions github-actions bot added the team: delivery Issue belongs to the self-hosted team label Mar 2, 2022
@mrsimonemms mrsimonemms force-pushed the as/status-proce branch 3 times, most recently from 170b4f9 to 5712f2b Compare March 2, 2022 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/S team: delivery Issue belongs to the self-hosted team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants