Skip to content

Updated the VM manifest to use the newly exported image for VM based preview-environments #8543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

fullmetalrooster
Copy link
Contributor

@fullmetalrooster fullmetalrooster commented Mar 2, 2022

Description

This updates the manifest to create VMs for preview-environments to the newly created image build by this commit via the gihub-runner https://github.com/gitpod-io/gitpod-packer-gcp-image/commit/622131d9b42ef8d64558f7e939fd17ff758bcab9.

Related Issue(s)

Fixes #

How to test

Create a new preview-environment.

Release Notes

None

Documentation

@meysholdt
Copy link
Member

meysholdt commented Mar 2, 2022

thx! Can you increase the disk size to 150GB? Otherwise, I worry the VM will not start.

@fullmetalrooster
Copy link
Contributor Author

thx! Can you increase the disk size to 150GB? Otherwise, I worry the VM will not start.

Done

@fullmetalrooster
Copy link
Contributor Author

@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #8543 (94084e0) into main (863bb02) will decrease coverage by 1.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8543      +/-   ##
==========================================
- Coverage   12.31%   11.17%   -1.14%     
==========================================
  Files          20       18       -2     
  Lines        1161      993     -168     
==========================================
- Hits          143      111      -32     
+ Misses       1014      880     -134     
+ Partials        4        2       -2     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 863bb02...94084e0. Read the comment docs.

@meysholdt
Copy link
Member

The VM works just fine; Merging.

@roboquat roboquat merged commit 03d0f73 into main Mar 3, 2022
@roboquat roboquat deleted the wth/up-prev-vm branch March 3, 2022 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants