Skip to content

Pass auth cookie as env variable #8549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Pass auth cookie as env variable #8549

merged 1 commit into from
Mar 3, 2022

Conversation

jeanp413
Copy link
Member

@jeanp413 jeanp413 commented Mar 2, 2022

Description

Pass auth cookie as env variable in ide tests

Related Issue(s)

Fixes #

How to test

  1. Run in terminal werft run github -j .werft/integration-tests-startup.yaml -f. (not working for now, wait till next stable on Friday) or run test manually go test -v github.com/gitpod-io/gitpod/test/tests/ide/vscode -kubeconfig=/home/gitpod/.kube/config -namespace=staging-jp-cookie-as-env -username=<username> (select insiders first in dashboard->preferences)

Release Notes

NONE

@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #8549 (dd52c0a) into main (7ac5d9d) will decrease coverage by 1.13%.
The diff coverage is n/a.

❗ Current head dd52c0a differs from pull request most recent head 7d4ac10. Consider uploading reports for the commit 7d4ac10 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8549      +/-   ##
==========================================
- Coverage   12.31%   11.17%   -1.14%     
==========================================
  Files          20       18       -2     
  Lines        1161      993     -168     
==========================================
- Hits          143      111      -32     
+ Misses       1014      880     -134     
+ Partials        4        2       -2     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ac5d9d...7d4ac10. Read the comment docs.

@jeanp413 jeanp413 marked this pull request as ready for review March 2, 2022 21:42
@jeanp413 jeanp413 requested a review from iQQBot March 2, 2022 21:48
@jeanp413
Copy link
Member Author

jeanp413 commented Mar 3, 2022

BTW tests will pass only in insiders as there was a change how we specify the initial folder when opening the workbench with playwright. We will release new stable 1.65 with the same changes as insiders tomorrow or most probably on Friday

@roboquat roboquat merged commit 3a4c664 into main Mar 3, 2022
@roboquat roboquat deleted the jp/cookie-as-env branch March 3, 2022 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants