Skip to content

Update UA logo #8571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Update UA logo #8571

merged 1 commit into from
Mar 3, 2022

Conversation

gtsiolis
Copy link
Contributor

@gtsiolis gtsiolis commented Mar 3, 2022

Description

Follow up from #8570 to a) straighten the line, b) use simpler SVG shapes, and c) use accessible colors as mentioned in #8570 (review).

Release Notes

NONE

@gtsiolis gtsiolis requested a review from a team March 3, 2022 15:23
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Mar 3, 2022
@gtsiolis gtsiolis marked this pull request as draft March 3, 2022 15:24
@gtsiolis gtsiolis force-pushed the gt/update-ua-logo branch from 056caa0 to 2cd5d69 Compare March 3, 2022 15:29
@gtsiolis gtsiolis marked this pull request as ready for review March 3, 2022 15:30
@gtsiolis gtsiolis mentioned this pull request Mar 3, 2022
@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #8571 (2cd5d69) into main (e931577) will decrease coverage by 1.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8571      +/-   ##
==========================================
- Coverage   12.31%   11.17%   -1.14%     
==========================================
  Files          20       18       -2     
  Lines        1161      993     -168     
==========================================
- Hits          143      111      -32     
+ Misses       1014      880     -134     
+ Partials        4        2       -2     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e931577...2cd5d69. Read the comment docs.

Copy link
Contributor

@mustard-mh mustard-mh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JanKoehnlein JanKoehnlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat roboquat merged commit ede9db9 into main Mar 3, 2022
@roboquat roboquat deleted the gt/update-ua-logo branch March 3, 2022 16:54
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Mar 3, 2022

Thanks @mustard-mh @JanKoehnlein! 🍔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants