Skip to content

Remove unused pod labels #8583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2022
Merged

Remove unused pod labels #8583

merged 2 commits into from
Mar 4, 2022

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Mar 3, 2022

Description

Remove deprecated labels

Release Notes

Remove unused pod labels

Remove unused labels
@aledbf aledbf requested review from a team March 3, 2022 21:38
@github-actions github-actions bot added team: delivery Issue belongs to the self-hosted team team: workspace Issue belongs to the Workspace team labels Mar 3, 2022
sagor999
sagor999 previously approved these changes Mar 3, 2022
Update golden files
@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #8583 (082cd86) into main (ede9db9) will increase coverage by 15.10%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8583       +/-   ##
===========================================
+ Coverage   12.31%   27.42%   +15.10%     
===========================================
  Files          20       44       +24     
  Lines        1161     5761     +4600     
===========================================
+ Hits          143     1580     +1437     
- Misses       1014     4064     +3050     
- Partials        4      117      +113     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
components-ws-manager-app 39.43% <ø> (?)
install-installer-raw-app 4.50% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/ws-manager/pkg/manager/create.go 82.93% <ø> (ø)
install/installer/pkg/common/common.go 4.45% <0.00%> (ø)
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go
components/ws-manager/pkg/manager/status.go 74.77% <0.00%> (ø)
install/installer/pkg/common/display.go 0.00% <0.00%> (ø)
...l/installer/pkg/components/ws-manager/tlssecret.go 0.00% <0.00%> (ø)
...omponents/ws-manager/pkg/manager/pod_controller.go 0.00% <0.00%> (ø)
install/installer/pkg/common/render.go 0.00% <0.00%> (ø)
components/ws-manager/pkg/manager/manager.go 20.28% <0.00%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ede9db9...082cd86. Read the comment docs.

@roboquat roboquat merged commit 2863582 into main Mar 4, 2022
@roboquat roboquat deleted the aledbf/labels branch March 4, 2022 08:12
@roboquat roboquat added the deployed: workspace Workspace team change is running in production label Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production release-note size/M team: delivery Issue belongs to the self-hosted team team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants