[prebuilds] Introduce 'failed' state for prebuilds #8602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenefftinge
force-pushed
the
se/prebuilds-failed
branch
from
2d0a277 to
b8f3157
Compare
|
/werft run 👍 started the job as gitpod-build-se-prebuilds-failed.2 |
svenefftinge
force-pushed
the
se/prebuilds-failed
branch
from
b8f3157 to
6dcafb8
Compare
|
/werft run 👍 started the job as gitpod-build-se-prebuilds-failed.4 |
Codecov Report
@@ Coverage Diff @@
## main #8602 +/- ##
===========================================
- Coverage 28.98% 11.17% -17.81%
===========================================
Files 150 18 -132
Lines 23118 993 -22125
===========================================
- Hits 6700 111 -6589
+ Misses 15808 880 -14928
+ Partials 610 2 -608
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
AlexTugarev
reviewed
Mar 7, 2022
svenefftinge
force-pushed
the
se/prebuilds-failed
branch
from
6dcafb8 to
2d8d852
Compare
AlexTugarev
reviewed
Mar 7, 2022
|
The error handling makes sense and the changes look good. I'm just not sure about the presentation on the dashboard, it seems to be the same as the "headless task failed" case. Could we render the "system error" case differently? |
Distinguish between failed tasks but finished prebuilds and fully failed prebuilds (no snapshot) fixes #8592
svenefftinge
force-pushed
the
se/prebuilds-failed
branch
from
2d8d852 to
4769e41
Compare
|
/werft run 👍 started the job as gitpod-build-se-prebuilds-failed.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a "failure" state for prebuilds that have entirely failed to finish.
This is to distinguish them from failed tasks but finished rebuilds.
Related Issue(s)
fixes #8592
Release Notes