Skip to content

Update debug script #8606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2022
Merged

Update debug script #8606

merged 1 commit into from
Mar 4, 2022

Conversation

Furisto
Copy link
Member

@Furisto Furisto commented Mar 4, 2022

Description

  • Add required parameter ImageRepoBase
  • Bail out if one of the steps fail
  • Ensure history of images is kept, so that one can easily switch back to a previous image

Related Issue(s)

n.a.

How to test

  • Call debug.sh

Release Notes

NONE

/werft no-preview

@Furisto Furisto requested a review from a team March 4, 2022 16:04
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Mar 4, 2022
@sagor999
Copy link
Contributor

sagor999 commented Mar 4, 2022

/hold
Changes look good, but holding due to build failure. I don't think it is related to your change though, so feel free to remove hold.

@Furisto
Copy link
Member Author

Furisto commented Mar 4, 2022

Yeah, it is just a problem with issuing the certificates

@Furisto
Copy link
Member Author

Furisto commented Mar 4, 2022

/unhold

@mustard-mh
Copy link
Contributor

/hold
this block merge pool

@mustard-mh
Copy link
Contributor

mustard-mh commented Mar 4, 2022

/werft run

👍 started the job as gitpod-build-fo-up-debug.1
/unhold

@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #8606 (1641927) into main (6d59526) will increase coverage by 2.98%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            main    #8606      +/-   ##
=========================================
+ Coverage   8.19%   11.17%   +2.98%     
=========================================
  Files         34       18      -16     
  Lines       2392      993    -1399     
=========================================
- Hits         196      111      -85     
+ Misses      2191      880    -1311     
+ Partials       5        2       -3     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
install-installer-raw-app ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
install/installer/pkg/common/render.go
...components/ws-manager/unpriviledged-rolebinding.go
...nstall/installer/pkg/components/ws-manager/role.go
install/installer/pkg/common/display.go
install/installer/pkg/common/objects.go
install/installer/pkg/common/ca.go
...staller/pkg/components/ws-manager/networkpolicy.go
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go
install/installer/pkg/common/storage.go
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d59526...1641927. Read the comment docs.

@roboquat roboquat merged commit e798aa6 into main Mar 4, 2022
@roboquat roboquat deleted the fo/up-debug branch March 4, 2022 20:37
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/S team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants