Skip to content

[core-dev] change registry-facade PodSecurityPolicy #8613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2022
Merged

Conversation

iQQBot
Copy link
Contributor

@iQQBot iQQBot commented Mar 4, 2022

Description

[core-dev] change registry-facade PodSecurityPolicy

Related Issue(s)

Fixes #

How to test

Start a workspace, it can start
check "$NAMESPACE-ns-registry-facade PodSecurityPolicy see host port is set same than registry-facade's host port

Release Notes

NONE

Documentation

Copy link
Member

@aledbf aledbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aledbf
Copy link
Member

aledbf commented Mar 4, 2022

@iQQBot thanks!

@roboquat roboquat merged commit f893ad5 into main Mar 4, 2022
@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #8613 (fab4123) into main (6c71369) will increase coverage by 2.98%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            main    #8613      +/-   ##
=========================================
+ Coverage   8.19%   11.17%   +2.98%     
=========================================
  Files         34       18      -16     
  Lines       2392      993    -1399     
=========================================
- Hits         196      111      -85     
+ Misses      2191      880    -1311     
+ Partials       5        2       -3     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
install-installer-raw-app ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
install/installer/pkg/common/render.go
...components/ws-manager/unpriviledged-rolebinding.go
...nstall/installer/pkg/components/ws-manager/role.go
install/installer/pkg/common/display.go
install/installer/pkg/common/objects.go
install/installer/pkg/common/ca.go
...staller/pkg/components/ws-manager/networkpolicy.go
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go
install/installer/pkg/common/storage.go
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c71369...fab4123. Read the comment docs.

@roboquat roboquat deleted the pd/test branch March 4, 2022 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants