Skip to content

[installer] Add network policy for registry-facade access to coredns #8622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Mar 6, 2022

Description

kube-dns and coredns (helm chart) use different labels.

Release Notes

[installer] Add network policy for registry-facade access to coredns

[installer] Add network policy for coredns
@aledbf aledbf requested a review from a team March 6, 2022 00:41
@github-actions github-actions bot added the team: delivery Issue belongs to the self-hosted team label Mar 6, 2022
@codecov
Copy link

codecov bot commented Mar 6, 2022

Codecov Report

Merging #8622 (9fe8cc6) into main (f893ad5) will decrease coverage by 4.97%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main   #8622      +/-   ##
=========================================
- Coverage   12.31%   7.34%   -4.98%     
=========================================
  Files          20      32      +12     
  Lines        1161    2234    +1073     
=========================================
+ Hits          143     164      +21     
- Misses       1014    2067    +1053     
+ Partials        4       3       -1     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
install-installer-raw-app 4.27% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
install/installer/pkg/common/networkpolicies.go 0.00% <0.00%> (ø)
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go
install/installer/pkg/common/storage.go 0.00% <0.00%> (ø)
install/installer/pkg/common/display.go 0.00% <0.00%> (ø)
...installer/pkg/components/ws-manager/rolebinding.go 0.00% <0.00%> (ø)
install/installer/pkg/common/ca.go 0.00% <0.00%> (ø)
...nstall/installer/pkg/components/ws-manager/role.go 0.00% <0.00%> (ø)
...l/installer/pkg/components/ws-manager/configmap.go 23.75% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f893ad5...9fe8cc6. Read the comment docs.

Copy link
Contributor

@Pothulapati Pothulapati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roboquat roboquat merged commit 103f835 into main Mar 7, 2022
@roboquat roboquat deleted the aledbf/pol branch March 7, 2022 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note size/S team: delivery Issue belongs to the self-hosted team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants