Skip to content

Disable cache reclaim when cgroup v2. #8626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Disable cache reclaim when cgroup v2. #8626

wants to merge 1 commit into from

Conversation

utam0k
Copy link
Contributor

@utam0k utam0k commented Mar 7, 2022

Description

Because cache reclaim supports only when using cgroup v1.

Related Issue(s)

Fixes #8497

How to test

  1. Prepare an environment with cgroup v2 enabled e.g. gitpod-k3s-202202181722
  2. Start a workspace
  3. Confirm that ws-daemon doesn't complain error message about the cache reclaim

Release Notes

Disable cache reclaim when cgroup v2

Documentation

No

Because cache reclaim supports only when using cgroup v1.
@utam0k
Copy link
Contributor Author

utam0k commented Mar 7, 2022

/werft run

👍 started the job as gitpod-build-to-cgv2-cache.2

@utam0k
Copy link
Contributor Author

utam0k commented Mar 7, 2022

This PR is a draft because this pr is waiting for solving this discussion.
#8471 (comment)

@utam0k
Copy link
Contributor Author

utam0k commented Mar 7, 2022

/werft run

👍 started the job as gitpod-build-to-cgv2-cache.3

@utam0k
Copy link
Contributor Author

utam0k commented Mar 7, 2022

/werft run

👍 started the job as gitpod-build-to-cgv2-cache.4

@utam0k
Copy link
Contributor Author

utam0k commented Mar 7, 2022

/werft run

👍 started the job as gitpod-build-to-cgv2-cache.5

@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #8626 (91b2abf) into main (f893ad5) will increase coverage by 2.42%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8626      +/-   ##
==========================================
+ Coverage   12.31%   14.74%   +2.42%     
==========================================
  Files          20       50      +30     
  Lines        1161     4788    +3627     
==========================================
+ Hits          143      706     +563     
- Misses       1014     4012    +2998     
- Partials        4       70      +66     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
components-ws-daemon-app 21.13% <0.00%> (?)
components-ws-daemon-lib 21.13% <0.00%> (?)
install-installer-raw-app 4.30% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/ws-daemon/pkg/daemon/daemon.go 0.00% <0.00%> (ø)
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go
install/installer/pkg/common/storage.go 0.00% <0.00%> (ø)
...onents/ws-daemon/pkg/internal/session/workspace.go 50.73% <0.00%> (ø)
components/ws-daemon/pkg/cpulimit/cpulimit.go 68.83% <0.00%> (ø)
components/ws-daemon/pkg/cpulimit/bandwidth.go 71.42% <0.00%> (ø)
...l/installer/pkg/components/ws-manager/configmap.go 23.75% <0.00%> (ø)
.../installer/pkg/components/ws-manager/deployment.go 0.00% <0.00%> (ø)
install/installer/pkg/common/objects.go 0.00% <0.00%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f893ad5...91b2abf. Read the comment docs.

@utam0k utam0k closed this Mar 7, 2022
@utam0k utam0k deleted the to/cgv2-cache branch March 15, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make cache reclaim support v2
2 participants