.werft/build: Cleaning code #8636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #8636 +/- ##
==========================================
- Coverage 14.87% 11.17% -3.70%
==========================================
Files 52 18 -34
Lines 4963 993 -3970
==========================================
- Hits 738 111 -627
+ Misses 4153 880 -3273
+ Partials 72 2 -70
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
mads-hartmann
previously requested changes
Mar 7, 2022
|
|
||
| async function preCommitCheck(werft: Werft) { | ||
| werft.log("pre-commit checks", "Running pre-commit hooks.") | ||
| try { |
There was a problem hiding this comment.
As you're re-throwing the error I would suggest removing the try/catch logic here all-together
There was a problem hiding this comment.
Ah nice catch...
I think we could follow this pattern on other areas too:
- One public function that is directly called by build.ts
- The public function would call private functions on a try-catch block
- Private functions would throw errors instead of running
werft.fail
Keep built.ts clean by removing branch lenght check from it Add branch length check to validation phase, while making logic clearer with better error handling Signed-off-by: ArthurSens <[email protected]>
meysholdt
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Keep built.ts cleaner by removing branch length check from it
Add branch length check to validation phase, as it seems more appropriate, while making logic clearer with better error handling
Release Notes