Skip to content

werft/vm/manifest: Disable google cloud agent #8639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2022
Merged

Conversation

ArthurSens
Copy link
Contributor

Signed-off-by: ArthurSens [email protected]

Description

Disabling google-cloud agent during boot time aiming for faster boot

Related Issue(s)

Fixes https://github.com/gitpod-io/ops/issues/1443

How to test

Release Notes

NONE

@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #8639 (bb6bdb5) into main (103f835) will decrease coverage by 3.69%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8639      +/-   ##
==========================================
- Coverage   14.87%   11.17%   -3.70%     
==========================================
  Files          52       18      -34     
  Lines        4963      993    -3970     
==========================================
- Hits          738      111     -627     
+ Misses       4153      880    -3273     
+ Partials       72        2      -70     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
components-ws-daemon-app ?
components-ws-daemon-lib ?
install-installer-raw-app ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/ws-daemon/pkg/daemon/daemon.go
...l/installer/pkg/components/ws-manager/configmap.go
...installer/pkg/components/ws-manager/rolebinding.go
install/installer/pkg/common/common.go
...nstall/installer/pkg/components/ws-manager/role.go
.../installer/pkg/components/ws-manager/deployment.go
...components/ws-manager/unpriviledged-rolebinding.go
components/ws-daemon/pkg/content/archive.go
components/ws-daemon/pkg/internal/session/store.go
components/ws-daemon/pkg/daemon/markunmount.go
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 103f835...bb6bdb5. Read the comment docs.

systemctl disable google-startup-scripts &
systemctl disable google-osconfig-agent &
systemctl disable google-oslogin-cache.timer &
systemctl disable google-shutdown-scripts &
Copy link
Contributor

@fullmetalrooster fullmetalrooster Mar 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can simplify it by using systemctl disable --now <SERVICE>.

@roboquat roboquat merged commit 952450b into main Mar 8, 2022
@roboquat roboquat deleted the as/disable-g branch March 8, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants