[dashboard] display warning for latest IDE versions #8783

mustard-mh · 2022-03-14T03:48:41Z

Description

Allow users to switch IDE version (latest) with one checkbox toggle only
Display warning for latest IDE versions on the loading screen for latest versions like VS Code Insiders and EAP of JB products

Add test cases
Need design
- Cannot find switch ide design, color detail needed (dark mode?)
- ~~We need to change margin-top of ws starting page, like Running status~~

Switch IDE	Warning	Warning Dark

You can see the new Alert component [~~all here~~] removed in this commit 3abafdf

Related Issue(s)

Fixes #8028, #8786

How to test

Switch your Preferences with Latest Release marked
Open workspace, see if warning display

How to deploy

Do WebApp deployment first, then IDE deploy

Release Notes

Display warning message when users choose latest IDE
Update IDE choose preferences UI

Documentation

codecov · 2022-03-14T03:49:25Z

Codecov Report

Merging #8783 (d40ad5c) into main (a567595) will increase coverage by 3.83%.
The diff coverage is n/a.

❗ Current head d40ad5c differs from pull request most recent head 00d7945. Consider uploading reports for the commit 00d7945 to get more accurate results

@@            Coverage Diff            @@
##            main    #8783      +/-   ##
=========================================
+ Coverage   7.34%   11.17%   +3.83%     
=========================================
  Files         32       18      -14     
  Lines       2234      993    -1241     
=========================================
- Hits         164      111      -53     
+ Misses      2067      880    -1187     
+ Partials       3        2       -1

Flag	Coverage Δ
components-gitpod-cli-app	`11.17% <ø> (ø)`
install-installer-raw-app	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
.../installer/pkg/components/ws-manager/deployment.go
...staller/pkg/components/ws-manager/networkpolicy.go
...l/installer/pkg/components/ws-manager/tlssecret.go
...components/ws-manager/unpriviledged-rolebinding.go
install/installer/pkg/common/objects.go
install/installer/pkg/common/common.go
...nstall/installer/pkg/components/ws-manager/role.go
...l/installer/pkg/components/ws-manager/configmap.go
install/installer/pkg/common/ca.go
install/installer/pkg/common/display.go
... and 4 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

akosyakov · 2022-03-14T07:43:55Z

@gtsiolis Could you have a look at design for this one? 🙏

akosyakov · 2022-03-14T08:02:46Z

While waiting for @gtsiolis, I think this callout should not be put at the position of usual workspace warnings, but rather at the bottom as a new one. We want to inform a user that he is running latest version, not scare into thinking that something is already wrong with the workspace.

gtsiolis · 2022-03-14T16:51:21Z

Adding this to In Progress.

Agree with @akosyakov in #8783 (comment), this could be a sublte info alert further below.

ETA: Will take a look later today or tomorrow. ⏱️

gtsiolis · 2022-03-15T10:33:55Z

Looking at this now! 👀

mustard-mh · 2022-03-16T19:58:42Z

@gtsiolis I updated this PR, you can see PR description

gtsiolis · 2022-03-16T22:40:28Z

Looking at this now! 👀

gtsiolis

This is great, @mustard-mh! 🔮

Sorry for not posting any detailed specs sooner. 🙏

Left some feedback in the comments below, let me know if something is not clear enough. Also, if any comment or suggestion feels like out of the scope of this PR or could significantly increase the implementaiton scope, feel free to ignore it and open follow up issue(s). 🏓

Feedback is always welcome! 🥯

chart/templates/server-ide-configmap.yaml

components/dashboard/src/start/StartPage.tsx

install/installer/pkg/components/server/ide/configmap.go

components/dashboard/src/settings/Preferences.tsx

chart/templates/server-ide-configmap.yaml

components/dashboard/src/start/StartPage.tsx

components/dashboard/src/components/SelectableCardSolid.tsx

gtsiolis · 2022-03-16T23:36:13Z

Just wanted to repost here some screenshots of the preferences. This is a great improvement already without tackling any of the design comments above! Thanks for tackling this, @mustard-mh! ✨

Cc @akosyakov @loujaybee

BEFORE	AFTER

components/dashboard/src/start/StartPage.tsx

gtsiolis · 2022-04-08T17:17:57Z

components/dashboard/src/settings/Preferences.tsx

-                                            ))}
-                                        </ul>
-                                    </InfoBox>
-                                )}
                                <p className="text-left w-full text-gray-500">
                                    The <strong>JetBrains desktop IDEs</strong> are currently in beta.{" "}


question: Posting one last question here for future reference which could be out of the scope of this PR. Do we still consider JetBrains editor support beta? Maybe this beta notice is something to consider removing in a future PR. Cc @akosyakov @loujaybee

I think it's still in beta, no GA now

Yes, everything is in BETA but VS Code Web.

Thanks for clarifying, @iQQBot @akosyakov! 🙏

mustard-mh · 2022-04-08T17:47:20Z

To be more clear, for compatibility:

IDE deployment must be after WebApp deploy, so hope this PR merge before WebApp is deployed to unblock the deployment of IDE

cc @geropl

geropl · 2022-04-11T07:00:25Z

IDE deployment must be after WebApp deploy, so hope this PR merge before WebApp is deployed to unblock the deployment of IDE

@mustard-mh 👍 Next plannecd deployment is tomorrow, 10:00am CET.

andreafalzetti · 2022-04-11T08:15:39Z

components/server/src/workspace/workspace-starter.ts

+    }
+    if (!data.ideImage) {
+        data.ideImage = defaultIdeImage;
+        // throw new Error("cannot choose correct browser ide");


do we need this comment?

akosyakov · 2022-04-11T13:06:25Z

What is holding it back? Webapp team release is tomorrow.

mustard-mh · 2022-04-11T13:07:54Z

/unhold

geropl · 2022-04-11T14:00:56Z

What is holding it back? Webapp team release is tomorrow.

@akosyakov you need to review as well it says: 👇 🤷

gtsiolis · 2022-04-11T14:07:01Z

Woohoo! Thank you @mustard-mh for working on this and @iQQBot @andreafalzetti @akosyakov @geropl for reviewing and helping merge this. Much looking forward to seeing this in production soon. 🏀

roboquat added release-note do-not-merge/work-in-progress size/XXL labels Mar 14, 2022

mustard-mh force-pushed the hw/fix-8028 branch from cdba332 to d40ad5c Compare March 14, 2022 06:44

gtsiolis requested a review from a team March 14, 2022 16:51

mustard-mh closed this Mar 16, 2022

mustard-mh force-pushed the hw/fix-8028 branch from d40ad5c to ffe6f48 Compare March 16, 2022 17:52

roboquat added size/XS and removed size/XXL labels Mar 16, 2022

mustard-mh reopened this Mar 16, 2022

roboquat added size/L and removed size/XS labels Mar 16, 2022

mustard-mh force-pushed the hw/fix-8028 branch 3 times, most recently from abd5874 to 639f507 Compare March 16, 2022 19:40

gtsiolis added team: webapp Issue belongs to the WebApp team and removed team: webapp Issue belongs to the WebApp team labels Mar 16, 2022

gtsiolis suggested changes Mar 16, 2022

View reviewed changes

gtsiolis reviewed Mar 17, 2022

View reviewed changes

components/dashboard/src/start/StartPage.tsx Outdated Show resolved Hide resolved

mustard-mh force-pushed the hw/fix-8028 branch from f24912f to 3662485 Compare March 17, 2022 17:29

roboquat added size/XL and removed size/L labels Mar 17, 2022

gtsiolis reviewed Apr 8, 2022

View reviewed changes

iQQBot approved these changes Apr 11, 2022

View reviewed changes

andreafalzetti reviewed Apr 11, 2022

View reviewed changes

andreafalzetti approved these changes Apr 11, 2022

View reviewed changes

roboquat removed the do-not-merge/hold label Apr 11, 2022

mustard-mh requested a review from geropl April 11, 2022 13:52

geropl approved these changes Apr 11, 2022

View reviewed changes

roboquat merged commit c5ca6ed into main Apr 11, 2022

roboquat deleted the hw/fix-8028 branch April 11, 2022 14:00

gtsiolis mentioned this pull request Apr 11, 2022

Switch IDE version with one toggle #8786

Closed

roboquat added the deployed: webapp Meta team change is running in production label Apr 12, 2022

loujaybee mentioned this pull request Apr 12, 2022

Proposal: Experimental features interface / API #7026

Open

roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Apr 12, 2022

gtsiolis mentioned this pull request Apr 13, 2022

[dashboard] add notice for stable back and change latest desc #9293

Merged

jeanp413 mentioned this pull request Apr 18, 2022

vscode about dialog don't show insiders label #9380

Closed

This was referenced Apr 19, 2022

Improve warning alert component design #7613

Closed

Migrate AlertBox components to the new Alert component #9411

Closed

mustard-mh mentioned this pull request Apr 26, 2022

[Dashboard] Increase IDE awareness during onboarding #9432

Merged

gtsiolis mentioned this pull request May 6, 2022

Improve alert component accessibility (colors, icons, etc) #9834

Open

jldec mentioned this pull request May 15, 2022

Alert component for errors and notifications #8933

Open

This was referenced May 18, 2022

[server-ide] add label to desktop VSCode #9883

Closed

Update theme selection components #10111

Merged

gtsiolis mentioned this pull request Jun 30, 2022

Remove the latest editor release warning alert on workspace time out #11035

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[dashboard] display warning for latest IDE versions #8783

[dashboard] display warning for latest IDE versions #8783

mustard-mh commented Mar 14, 2022 •

edited

Loading

codecov bot commented Mar 14, 2022 •

edited

Loading

akosyakov commented Mar 14, 2022 •

edited by werft-gitpod-dev-com bot

Loading

akosyakov commented Mar 14, 2022

gtsiolis commented Mar 14, 2022 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis commented Mar 15, 2022 •

edited by werft-gitpod-dev-com bot

Loading

mustard-mh commented Mar 16, 2022 •

edited

Loading

gtsiolis commented Mar 16, 2022 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis left a comment •

edited

Loading

gtsiolis commented Mar 16, 2022 •

edited

Loading

gtsiolis Apr 8, 2022 •

edited

Loading

iQQBot Apr 11, 2022

akosyakov Apr 11, 2022

gtsiolis Apr 11, 2022

mustard-mh commented Apr 8, 2022 •

edited

Loading

geropl commented Apr 11, 2022

andreafalzetti Apr 11, 2022

akosyakov commented Apr 11, 2022 •

edited

Loading

mustard-mh commented Apr 11, 2022

geropl commented Apr 11, 2022

gtsiolis commented Apr 11, 2022 •

edited

Loading

[dashboard] display warning for latest IDE versions #8783

[dashboard] display warning for latest IDE versions #8783

Conversation

mustard-mh commented Mar 14, 2022 • edited Loading

Description

Related Issue(s)

How to test

How to deploy

Release Notes

Documentation

codecov bot commented Mar 14, 2022 • edited Loading

Codecov Report

akosyakov commented Mar 14, 2022 • edited by werft-gitpod-dev-com bot Loading

akosyakov commented Mar 14, 2022

gtsiolis commented Mar 14, 2022 • edited by werft-gitpod-dev-com bot Loading

gtsiolis commented Mar 15, 2022 • edited by werft-gitpod-dev-com bot Loading

mustard-mh commented Mar 16, 2022 • edited Loading

gtsiolis commented Mar 16, 2022 • edited by werft-gitpod-dev-com bot Loading

gtsiolis left a comment • edited Loading

Choose a reason for hiding this comment

gtsiolis commented Mar 16, 2022 • edited Loading

gtsiolis Apr 8, 2022 • edited Loading

Choose a reason for hiding this comment

iQQBot Apr 11, 2022

Choose a reason for hiding this comment

akosyakov Apr 11, 2022

Choose a reason for hiding this comment

gtsiolis Apr 11, 2022

Choose a reason for hiding this comment

mustard-mh commented Apr 8, 2022 • edited Loading

geropl commented Apr 11, 2022

andreafalzetti Apr 11, 2022

Choose a reason for hiding this comment

akosyakov commented Apr 11, 2022 • edited Loading

mustard-mh commented Apr 11, 2022

geropl commented Apr 11, 2022

gtsiolis commented Apr 11, 2022 • edited Loading

mustard-mh commented Mar 14, 2022 •

edited

Loading

codecov bot commented Mar 14, 2022 •

edited

Loading

akosyakov commented Mar 14, 2022 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis commented Mar 14, 2022 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis commented Mar 15, 2022 •

edited by werft-gitpod-dev-com bot

Loading

mustard-mh commented Mar 16, 2022 •

edited

Loading

gtsiolis commented Mar 16, 2022 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis left a comment •

edited

Loading

gtsiolis commented Mar 16, 2022 •

edited

Loading

gtsiolis Apr 8, 2022 •

edited

Loading

mustard-mh commented Apr 8, 2022 •

edited

Loading

akosyakov commented Apr 11, 2022 •

edited

Loading

gtsiolis commented Apr 11, 2022 •

edited

Loading