[kots]: escape golang template variables for Helm resources #8892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helm parses Golang template variables when rendering the Kubernetes
objects. For the ws-manager config (and potentially others), this
breaks as this includes Golang template variables which is interpolated
at runtime.
Helm allows for escaping of Golang template variables if wrapped in
"{{``}}". The sed command searches for any line containing "{{" and
escapes it.
github-actions
bot
added
the
team: delivery
Pothulapati
approved these changes
Mar 22, 2022
There was a problem hiding this comment.
LGTM! Also, Good Find!
Was able to find that, the ws-manager requires the following templates in its config
"urlTemplate": "https://{{ .Prefix }}.ws.tarun.self-hosted.com",
"portUrlTemplate": "https://{{ .WorkspacePort }}-{{ .Prefix }}.ws.tarun.self-hosted.com",
which is then replaced by the following after the sed command:
{{` "urlTemplate": "https://{{ .Prefix }}.ws.tarun.self-hosted.com",`}}
{{` "portUrlTemplate": "https://{{ .WorkspacePort }}-{{ .Prefix }}.ws.tarun.self-hosted.com",`}}
|
@Pothulapati correct analysis 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Helm parses Golang template variables when rendering the Kubernetes objects. For the ws-manager config (and potentially others), this breaks as this includes Golang template variables which is interpolated at runtime.
Helm allows for escaping of Golang template variables if wrapped in
{{`x`}}. The sed command searches for any line containing{{and escapes the whole line - because we use backticks and it's (currently) only in a JSON configmap, this escapes everything adequately.How to test
Deploy via KOTS and run a workspace
Release Notes
Documentation