Skip to content

Add new VS Code domain to config maps #9024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2022
Merged

Add new VS Code domain to config maps #9024

merged 1 commit into from
Apr 1, 2022

Conversation

filiptronicek
Copy link
Member

@filiptronicek filiptronicek commented Mar 30, 2022

Description

This change is needed for VS Code versions after 1.66.0, because they no longer use vscode-webview.net as the host domain for their webviews. Instead, they started using vscode-cdn.net.

Related Issue(s)

This is needed for #9020
This is not needed for VS Code 1.66 immediately, but it will be needed in the next release for stable and for insiders right after the release of 1.66.

Release Notes

NONE

@filiptronicek filiptronicek requested a review from a team March 30, 2022 16:08
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Mar 30, 2022
@filiptronicek
Copy link
Member Author

/hold as the code commit update is only there for testing, will need to revert it and squash commits before merging

@jeanp413
Copy link
Member

Also need to update in ops repo here

@filiptronicek
Copy link
Member Author

/unhold

Copy link
Member

@aledbf aledbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat roboquat merged commit eede514 into main Apr 1, 2022
@roboquat roboquat deleted the ft/testing-vsc-1.66 branch April 1, 2022 08:41
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/S team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants