Switch KOTS publish to use envvars #9061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrsimonemms
force-pushed
the
sje/push-to-kots
branch
from
b56b7a5 to
3bf4fdd
Compare
mrsimonemms
force-pushed
the
sje/push-to-kots
branch
from
3bf4fdd to
d826d54
Compare
mrsimonemms
changed the title
roboquat
added
release-note-none
and removed
do-not-merge/release-note-label-needed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The KOTS publish job was causing random failures in
mainand other branches. This was due to thekubectl get secrets replicated -n werftcommand not always having the credentials to get the secret.As suggested by @corneliusludmann in the original PR, we this secret is already loaded to the Werft job so this bit is actually redundant.
As we have named the envvars in the manner that the Replicated CLI expects them, there's no need to assign the values here.
How to test
Run a werft job
Release Notes
Documentation