Skip to content

Fix db-migrations in Helm chart #9068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2022
Merged

Fix db-migrations in Helm chart #9068

merged 1 commit into from
Apr 1, 2022

Conversation

meysholdt
Copy link
Member

@meysholdt meysholdt commented Apr 1, 2022

Description

Related Issue(s)

Fixes #8829

How to test

Release Notes

NONE

Documentation

/werft with-helm=true
/werft with-clean-slate-deployment=true

@meysholdt
Copy link
Member Author

With these changes, db-migrations finish successfully in preview envs.

@meysholdt meysholdt marked this pull request as ready for review April 1, 2022 13:19
@meysholdt meysholdt requested a review from ArthurSens April 1, 2022 13:19
@ArthurSens
Copy link
Contributor

ArthurSens commented Apr 1, 2022

Do you know if your branch includes the change announced here?

It would be good to see a build succeeding before approving 🙂

@roboquat roboquat added size/S and removed size/XS labels Apr 1, 2022
@meysholdt
Copy link
Member Author

yes, my branch did include that change. Turns out, a second change is necessary. I've rebased on that change now.

@meysholdt
Copy link
Member Author

The build succeeded :)

Copy link
Contributor

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Werft can no longer build my Pull Request (with-helm, with-payment)
3 participants