-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[public-api] Caddy serves gRPC port instead of http #9482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
765a869
to
3f4ce9e
Compare
/werft run with-vm=true 👍 started the job as gitpod-build-mp-papi-caddy-grpc.22 |
/werft run with-vm=true with-clean-slate-deployment=true 👍 started the job as gitpod-build-mp-papi-caddy-grpc.27 |
b8b4f3c
to
40535a4
Compare
/werft run 👍 started the job as gitpod-build-mp-papi-caddy-grpc.31 |
05b6e25
to
ae270b8
Compare
bfecc0a
to
2306861
Compare
/werft run with-vm=true with-clean-slate-deployment=true 👍 started the job as gitpod-build-mp-papi-caddy-grpc.52 |
2306861
to
42dfb99
Compare
If you want to have a laugh, it took about a week to figure out the right 10 lines (or so) in this PR.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
For now, we've been serving HTTP to easily show the server runs. But we actually need to serve the gRPC port for the API.
gRPC requires that we know the cert of the server, such that we can establish a TLS connection.
Related Issue(s)
How to test
The easy way:
cd components/public-api-server/cmd
go run main.go workspace get --address apimp-papi-caddy-grpc.preview.gitpod-dev.com:443
The hard way:
*.<domain>
in preview envs withcomponents/public-api-server/integration_test.go
with, updatepemServerCA
path to where you wrote thetls.crt
Release Notes
Documentation
NONE
/werft with-vm