Skip to content

Build: never lose STDOUT or STDERR when processes fail #9557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2022
Merged

Build: never lose STDOUT or STDERR when processes fail #9557

merged 1 commit into from
Apr 27, 2022

Conversation

meysholdt
Copy link
Member

@meysholdt meysholdt commented Apr 26, 2022 •
edited
Loading

Description

When a Werft job fails, we always need to have all information available that hint at potential causes.
Thus:

  • don't lose STDOUT when there is STDERR.
  • don't lose STDOUT and STDERR when no slice is given.

Related Issue(s)

How to test

Release Notes

NONE

Documentation

@meysholdt meysholdt requested a review from a team April 26, 2022 13:13
mads-hartmann
mads-hartmann approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@mads-hartmann mads-hartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, changes LGTM 🛹

@roboquat roboquat merged commit 8380022 into main Apr 27, 2022
@roboquat roboquat deleted the me/errormessages branch April 27, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mads-hartmann mads-hartmann mads-hartmann approved these changes

Assignees
No one assigned
Labels
release-note-none size/S team: devx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meysholdt @mads-hartmann @roboquat