Overwrite existing k3s entries in the kubectx in install-k3s-kubeconfig.sh #9579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed when switching bracnhes or when using clean-slate-deployment.
easyCZ
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently install-k3s-kubeconfig.sh would not update the .kube/config if it already had an entry to the k3s cluster. This means that your kubectx config can become stale if you change branches or use with-clean-slate-deployment.
The fix was the ensure that K3S_KUBECONFIG_PATH entries takes precedence over KUBECONFIG_PATH when merging the kubeconfig.
Related Issue(s)
No issue, was reported in our internal Slack here.
How to test
I tested this manually by using two branches with VMs and re-running the script after having changed branches. Before this changeset it didn't update the kubectx after the first invocation. With this changeset it did.
Release Notes
Documentation
N/A