[observability] Add filtering n update link n vars #9581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team: IDE
team: devx
team: webapp
Furisto
approved these changes
Apr 27, 2022
roboquat
added
deployed: IDE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have fixed the filtering logic and links in the dashboard.
When you filter for a value in the first panel the "Resource Details" section breaks i.e. does not show any values. This problem exists for the upstream dashboard due to the variables that are being used to filter values. Fixing this behaviour is our of scope for this PR.
I have checked that the behaviour of this dashboard is at par with the upstream dashboard, however, there could be some edge cases which are not discovered and ay not be fixable at all. The reason for this is that the dashboard was originally created with intention of drilling down on the resource usage of a single node independent of cluster and nodepool.
Related Issue(s)
#7645
How to test
You can import this dashboard to grafana but be sure that you replace the occurrence uid (there could be several)
xfpJB9FGz1with some different uid.Prince Test Node Resource Usage Metrics - Grafana - 27 April 2022 - Watch Video
Release Notes
Documentation