Fix gateway referrer won't set default IDE

[mustard-mh]

Description

Fix gateway referrer won't set default IDE

Related Issue(s)

Fixes #

How to test

1. Configure Gateway with prev env host
2. Open workspace via Gateway
3. Open with this URL to do same thing like step1 step2 https://hw-fix-gw-ide.staging.gitpod-dev.com/#referrer:jetbrains-gateway:pycharm/https://github.com/gitpod-io/template-python-flask
4. User setting should be the one you choose in gateway
5. No onboarding Modal in /workspaces page

We need to do other tests like

1. won't register just access <host>/#<repo> to see if workspace starts with code

Release Notes

NONE

Documentation

[akosyakov]

I wonder whether we can do it somehow differently? With a specific flag that a user explicitly configured IDE somehow? I afraid that someone will reintroduce and break again.

[mustard-mh]

I wonder whether we can do it somehow differently? With a specific flag that a user explicitly configured IDE somehow? I afraid that someone will reintroduce and break again.

Deal with adding a comment. internal chat

[felladrin]

To "Configure Gateway with prev env host" we need to recompile the Gateway plugin locally, @mustard-mh?

[mustard-mh]

To "Configure Gateway with prev env host" we need to recompile the Gateway plugin locally, @mustard-mh?

@felladrin no, you can done this step by using /#referre prefix, they are doing the same thing i.e https://hw-fix-gw-ide.staging.gitpod-dev.com/#referrer:jetbrains-gateway:pycharm/https://github.com/gitpod-io/template-python-flask

[felladrin]

Working great!

I've tested it also using Goland (JetBrains Gateway Link).
With a clean account on this preview environment, I've accessed the JetBrains Gateway Link, authorised GitHub access and JetBrains access, and the Gateway opened the link correctly on Goland.

Then, I closed the workspace and checked my Preferences, and confirmed it had Goland checked as my selected IDE.

And confirmed the Onboard Dialog was not being displayed on Workspaces page.

Then I accessed Pycharm link:

And then confirmed Goland was still selected on Preferences page, as it has been selected as my default editor by the previous step.

---

I've also confirmed, after deleting my account from that previous environment, that if I access this link (without refencing any JetBrains IDE), it will set my default editor as VS Code Browser.

But, in this case, as soon as I opened the Workspaces page, it displayed the Onboard dialog.
Was it expected when the user doesn't use #referrer?

[mustard-mh]

I've also confirmed, after deleting my account from that previous environment, that if I access this link (without refencing any JetBrains IDE), it will set my default editor as VS Code Browser.

But, in this case, as soon as I opened the Workspaces page, it displayed the Onboard dialog.
Was it expected when the user doesn't use #referrer?

@felladrin This is expected, only /#referrer prefix will change user default ide when user has not selected an IDE yet.

open with prefix only /#, workspace-starter will look for IDE, not found (not set yet), go with default code.

[felladrin]

Then it's good to go!

[mustard-mh]

@felladrin I remember as origin proposal, onboarding Modal in /workspaces will only work with

• User is onboarding user(not select IDE)
• No workspaces in /workspaces page

No idea why this changed, check condition 2 gone.

cc @andreafalzetti

[andreafalzetti]

@felladrin I remember as origin proposal, onboarding Modal in /workspaces will only work with

* User is onboarding user(not select IDE)

* No workspaces in `/workspaces` page

No idea why this changed, check condition 2 gone.

cc @andreafalzetti

I think during a refactor it got lost because it was not possible to start a workspace without the modal actually setting for the user their defaultIde, we can re-introduce the second condition if necessary cc @mustard-mh