Preivew Envs: Change with-vm from opt-in to opt-out #9672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables preview envs on Harvester by default and replaces the
with-vmWerft annotation with awithout-vmannotation.The
repository.branch.includes("with-vm")check should no longer be necessary because we only need it to activatewith-vmin load tests - an with this PR it's always activated.Related Issue(s)
Fixes #
How to test
werft run githubwill deploy the preview env on Harvester.werft run github -a wihtout-vm=truewill deploy the preview environment to the core-dev cluster.Release Notes
Documentation