kots: Support s3 backend with incluster registry #9701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pothulapati
force-pushed
the
tar/incluster-registry-s3
branch
from
3ddd9be to
7138703
Compare
mrsimonemms
reviewed
May 4, 2022
Pothulapati
force-pushed
the
tar/incluster-registry-s3
branch
from
7138703 to
46d7805
Compare
Currently, There seems to be a configuration issue, around s3 backend, and docker registry. The s3 option is available when `incluster` is disabled, which is confusing as s3 backend is supported when `incluster` registry is enabled. This PR fixes that by having this configured correctly. Signed-off-by: Tarun Pothulapati <[email protected]>
Pothulapati
force-pushed
the
tar/incluster-registry-s3
branch
from
46d7805 to
654a318
Compare
mrsimonemms
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, There seems to be a configuration issue, around
s3 backend, and docker registry. The s3 option is available
when
inclusteris disabled, which is confusing as s3backend is supported when
inclusterregistry is enabled.This PR fixes that by having this configured correctly.
Signed-off-by: Tarun Pothulapati [email protected]
Related Issue(s)
How to test
With
kots, You should now see an Storage backend option when inclusterregistry is enabled.
Release Notes
Documentation