Skip to content

[ws-daemon] Remove workspaceSizeLimit #9711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2022
Merged

[ws-daemon] Remove workspaceSizeLimit #9711

merged 1 commit into from
May 3, 2022

Conversation

csweichel
Copy link
Contributor

Description

Removes the outdated workspaceSizeLimit field from ws-daemon's configuration in the helm chart

How to test

  • Install using helm-chart
  • Make sure ws-daemon still starts

Release Notes

NONE

/werft without-vm
/werft with-helm

@csweichel
Copy link
Contributor Author

csweichel commented May 3, 2022

/werft r un

👎 unknown command: r
Use /werft help to list the available commands

@csweichel
Copy link
Contributor Author

csweichel commented May 3, 2022

/werft run

👍 started the job as gitpod-build-cw-fix-limit.1
(with .werft/ from main)

Copy link
Contributor

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and works as advertized, many thanks for the quick fix! 🙏

FYI this is a Helm follow-up to #9238

@roboquat roboquat merged commit 52f1467 into main May 3, 2022
@roboquat roboquat deleted the cw/fix-limit branch May 3, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants