-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[installer]: Add server chargebee configuration to the installer #9717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2c0d3f9
to
5289800
Compare
5289800
to
8843d3e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx, tested and looks good! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think a single commit instead of 3 for such a rather small change would be also sufficient?
Otherwise, change looks good so far. 🚀
Holding in case you want to squash the commits.
/hold
8843d3e
to
3ea80af
Compare
Thanks, I've squashed down to one commit. |
/unhold |
Description
One of the Webapp team's epics for Q2 is to use the Gitpod installer to deploy to Gitpod SaaS. In order to do that we will need to add additional configuration to the installer to make the output suitable for a SaaS deployment as opposed to a self-hosted deployment.
This PR makes it possible to configure the
server
component's chargebee configuration via new configuration surface in theexperimental
section of the installer config that allows specifying the name of a secret containing chargebee config. For installations on which payments should be enabled, we expect there to be a secret present in the cluster containing this configuration. For Gitpod SaaS, this is achieved via terraform as a cluster prerequisite:https://github.com/gitpod-io/ops/blob/8fb50515adbfa90a3435f2148660f7de8d70c219/terraform/modules/gitpod/main.tf#L31-L38
Related Issue(s)
Part of #9097
How to test
Create an installer config file containing this
experimental
section:Get a
versions.yaml
for use with the installer:Then invoke the installer as:
The
server
configmap will haveenablePayment
set totrue
and theserver
deployment will have an extra volume + volumemount:Release Notes
Documentation
None.