Skip to content

[installer]: Add server chargebee configuration to the installer #9717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2022

Conversation

andrew-farries
Copy link
Contributor

@andrew-farries andrew-farries commented May 3, 2022

Description

One of the Webapp team's epics for Q2 is to use the Gitpod installer to deploy to Gitpod SaaS. In order to do that we will need to add additional configuration to the installer to make the output suitable for a SaaS deployment as opposed to a self-hosted deployment.

This PR makes it possible to configure the server component's chargebee configuration via new configuration surface in the experimental section of the installer config that allows specifying the name of a secret containing chargebee config. For installations on which payments should be enabled, we expect there to be a secret present in the cluster containing this configuration. For Gitpod SaaS, this is achieved via terraform as a cluster prerequisite:

https://github.com/gitpod-io/ops/blob/8fb50515adbfa90a3435f2148660f7de8d70c219/terraform/modules/gitpod/main.tf#L31-L38

Related Issue(s)

Part of #9097

How to test

Create an installer config file containing this experimental section:

experimental:
  webapp:
    server:
      chargebeeSecret: "chargebee-config"

Get a versions.yaml for use with the installer:

docker run -it --rm "eu.gcr.io/gitpod-core-dev/build/versions:${version}" cat versions.yaml > versions.yaml

Then invoke the installer as:

go run . render --debug-version-file versions.yaml --config /path/to/config --use-experimental-config

The server configmap will have enablePayment set to true and the server deployment will have an extra volume + volumemount:

        - mountPath: /chargebee
          name: chargebee-config
          readOnly: true
      - name: chargebee-config
        secret:
          secretName: chargebee-config

Release Notes

Allow chargebee payment config to be specified via the installer for SaaS installations.

Documentation

None.

@andrew-farries andrew-farries force-pushed the af/installer-server-chargebee-config branch 3 times, most recently from 2c0d3f9 to 5289800 Compare May 3, 2022 13:59
@roboquat roboquat added size/M and removed size/S labels May 3, 2022
@andrew-farries andrew-farries force-pushed the af/installer-server-chargebee-config branch from 5289800 to 8843d3e Compare May 3, 2022 14:13
@andrew-farries andrew-farries marked this pull request as ready for review May 3, 2022 14:37
@andrew-farries andrew-farries requested review from a team May 3, 2022 14:37
@github-actions github-actions bot added team: delivery Issue belongs to the self-hosted team team: webapp Issue belongs to the WebApp team labels May 3, 2022
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, tested and looks good! 👍

Copy link
Contributor

@corneliusludmann corneliusludmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think a single commit instead of 3 for such a rather small change would be also sufficient?

Otherwise, change looks good so far. 🚀

Holding in case you want to squash the commits.

/hold

@andrew-farries andrew-farries force-pushed the af/installer-server-chargebee-config branch from 8843d3e to 3ea80af Compare May 4, 2022 08:52
@andrew-farries
Copy link
Contributor Author

Holding in case you want to squash the commits.

Thanks, I've squashed down to one commit.

@andrew-farries
Copy link
Contributor Author

/unhold

@roboquat roboquat merged commit 2093016 into main May 4, 2022
@roboquat roboquat deleted the af/installer-server-chargebee-config branch May 4, 2022 08:59
@roboquat roboquat added the deployed: webapp Meta team change is running in production label May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production release-note size/M team: delivery Issue belongs to the self-hosted team team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants