Use ports order from supervisor #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Is not Map in JS have insertion order? 🤔 |
@akosyakov According to its define (just know it), it will. But inside Found it because order not align to response's order in preview env So it makes sense to keep code inside |
ok, make sense 👍 |
akosyakov
force-pushed
the
gp-code/main
branch
2 times, most recently
from
bda0ea6 to
b724dee
Compare
mustard-mh
force-pushed
the
hw/port-order
branch
from
d167401 to
f604b77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports order is random in vscode now, because we don't clean up map in
portViewProvider.ts, this PR will make order respect to supervisor's respondingHow to test
Check with gitpod-io/gitpod#13788