Skip to content

Unable to switch to branches with names containing a '/' character #1851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
strandloper opened this issue Aug 28, 2023 · 12 comments · Fixed by #1857
Closed

Unable to switch to branches with names containing a '/' character #1851

strandloper opened this issue Aug 28, 2023 · 12 comments · Fixed by #1857
Labels
bug Something isn't working
Milestone

Comments

@strandloper
Copy link

Describe the bug
Since updating to version 0.24.0 this morning I am unable to use the switch branch feature in gitui.

To Reproduce
Steps to reproduce the behavior:

  1. Press '1' to go to the Status tab then 'b' to view Branches.
  2. Scroll up or down to select a different local branch whose name contains a '/' character then press Enter to switch to that branch.
  3. A switch branch error stating "git error:cannot locate local branch '23.05.1'; class=Reference (4); code=NotFound (-3)" is displayed
  4. Note that while the name of the branch is "release/23.05.1" the error message has dropped the "release/" portion.
  5. Attempting the same for a branch name that does not contain a '/' character, e.g. "Test" does not display an error and the branch is switched.

Expected behavior
I should be able to switch between branches whether they contain a '/' character or not.

Context (please complete the following information):

  • OS/Distro + Version: Windows 11 Version 22H2 (OS Build 22521.2134)
  • GitUI Version: 0.24.0
  • Rust version: N/A (installed from gitui.msi)
@strandloper strandloper added the bug Something isn't working label Aug 28, 2023
@extrawurst
Copy link
Collaborator

its introduced by 514e8f0 for #1809 by @lightsnowball

@extrawurst
Copy link
Collaborator

its fixed on master. hope to cut a patch release the coming days. want to get the CI pipeline improvements in before though (see #1852)

@paul-uz
Copy link

paul-uz commented Aug 30, 2023

@extrawurst any chance of extraditing this? It's a huge breaking change for me

@extrawurst
Copy link
Collaborator

@paul-uz feel free to revert back to 0.23 for the time being, it does not have this problem

@paul-uz
Copy link

paul-uz commented Aug 30, 2023

@extrawurst I tried, but I'm using brew and brew install [email protected] doesn't work

EDIT brew install [email protected] doesn't work either

@extrawurst
Copy link
Collaborator

extrawurst commented Aug 30, 2023

Here are the binaries: https://github.com/extrawurst/gitui/releases/tag/v0.23.0

brew does not keep older releases.

@extrawurst
Copy link
Collaborator

@paul-uz
Copy link

paul-uz commented Aug 30, 2023

@extrawurst sorry to be a pain, it's not coming through on Brew

@extrawurst
Copy link
Collaborator

extrawurst commented Aug 30, 2023

see Homebrew/homebrew-core#140883

@paul-uz
Copy link

paul-uz commented Aug 30, 2023

I'm looking at the link, but I don't understand what you mean, I am unable to upgrade gitui via brew

@extrawurst
Copy link
Collaborator

extrawurst commented Aug 30, 2023

its merged, its not in my hands how long the angels of caching take for it to reach users :)

but looking at it on my end: https://formulae.brew.sh/formula/gitui its up to date now:

Screenshot 2023-08-30 at 17 41 09

@paul-uz
Copy link

paul-uz commented Aug 30, 2023

It's just come through! Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants