Skip to content

Enter label #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
savchenko opened this issue Dec 25, 2020 · 6 comments
Closed

Enter label #464

savchenko opened this issue Dec 25, 2020 · 6 comments

Comments

@savchenko
Copy link

Describe the bug
Depending on the font used, Enter label ("left arrow") can be hard to comprehend.

To Reproduce

  1. Open gitui
  2. What does this arrow mean?
    image
    Is this backspace? Left arrow on the keyboard?
  3. No, it's Enter.

Expected behavior
Perhaps using "[Enter]" would make UI less prone to user error.

Context (please complete the following information):

  • OS/Distro + Version: Debian Bullseye (current testing)
  • GitUI Version: v0.11.0
extrawurst pushed a commit that referenced this issue Dec 25, 2020
@extrawurst
Copy link
Collaborator

extrawurst commented Dec 25, 2020

I get your point, but I like the reduced verbosity of those symbols. of course it requires them to be universally clear in the various fonts. I read the currently used \u{23ce} is particularly inconsistently implemented in various fonts. how does the following work for you?

Can you build from better-enter-symbol branch and let me know if this renders the same for you?

image

@savchenko
Copy link
Author

savchenko commented Dec 26, 2020

Not quite:

image

The font is "Consolas". Also, left/right arrows look suspicious here:
image

@extrawurst
Copy link
Collaborator

Also, left/right arrows look suspicious here:

It is not supposed to be left/right its top/bottom:
image

@extrawurst
Copy link
Collaborator

The problem with consolas is that I can't seem to get the original on my Mac, the remakes I can find don't even contain the characters you see, so I am kinda lost here :(

So longterm we could consider customisability of those texts/symbols (they are hardcoded now), short-term I would suggest to try a different terminal font (my fave is JetBrains Mono)

@extrawurst
Copy link
Collaborator

@savchenko let me know if you agree we can close this in favour of #465 ?

@savchenko
Copy link
Author

Absolutely, sounds like the best decision possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants