Skip to content

selected_tab in theme.ron might not do anything #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
star-szr opened this issue May 21, 2021 · 1 comment
Closed

selected_tab in theme.ron might not do anything #722

star-szr opened this issue May 21, 2021 · 1 comment
Milestone

Comments

@star-szr
Copy link
Contributor

star-szr commented May 21, 2021

Describe the bug
The selected tab does not appear to be overrideable via the theme. (theme.ron has a selected_tab key)

To Reproduce
Steps to reproduce the behavior:

  1. Edit theme.ron to change selected_tab to something wacky (I suggest Red or Magenta or Cyan)
  2. Launch gitui
  3. Open up various parts of the UI, and check for your color override (I couldn't find it anywhere)

Expected behavior
I would expect the selected tab (on launching gitui this should be "Status") to take the selected_tab value from the theme.ron config.

Screenshots

Screenshots from v0.2.6 (before initial color theme support was added)

0 2 6-light

0 2 6-dark

Context (please complete the following information):

  • OS/Distro + Version: Pop!_OS 20.10
  • GitUI Version: v0.15.0
  • Rust version: Not sure, but probably not relevant in this case. I installed gitui via nixpkgs but I can reproduce the behaviour by building gitui from source.

Additional context

Screenshots from v0.10.1 (after theme support was added, but before the selected tab was hardcoded to white)

0 10 1-light

0 10 1-dark

#719 is related.

@extrawurst
Copy link
Collaborator

Thanks! closed via #723

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants