Add command to edit selected file in editor #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pressing `e` while looking at a file in the _Status_ view will launch an external editor with the current file opened. The editor chosen is determined by the default logic introduced in gitui-org#114. An improvement to this in the future could be launching at the specific line at which the _Diff_ view is focused, but that seems to require a change in `FileDiff` which is a change bigger than this PR. Fixes gitui-org#166
jonstodle
force-pushed
the
feat/166-open-file-in-external-editor
branch
from
ee6b381 to
d691d7a
Compare
|
@jonstodle good work! ❤️ |
|
This is awesome, thanks! Looks like on Mac it opens |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pressing
ewhile looking at a file in the Status view will launch an external editor with the current file opened. The editor chosen is determined by the default logic introduced in #114.An improvement to this in the future could be launching at the specific line at which the Diff view is focused, but that seems to require a change in
FileDiffwhich is a change bigger than this PR.Fixes #166