-
-
Notifications
You must be signed in to change notification settings - Fork 605
Issue/768/support markdown emoji #866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
extrawurst
merged 17 commits into
gitui-org:master
from
andrewpollack:issue/768/support-markdown-emoji
Aug 23, 2021
Merged
Issue/768/support markdown emoji #866
extrawurst
merged 17 commits into
gitui-org:master
from
andrewpollack:issue/768/support-markdown-emoji
Aug 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My local |
extrawurst
requested changes
Aug 21, 2021
rather perform a graceful shutdown
Conflicts: CHANGELOG.md
extrawurst
approved these changes
Aug 23, 2021
@andrewpollack thanks for your contribution. Checkout d72dcdd To see what I improved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you again for the advice on the previous PR! This is helping me learn better Rust coding practices, and I very much appreciate it 😄
This Pull Request fixes/closes #768.
It changes the following:
gh-emoji
crate to dependencies.fn emojifi_string(s: &str) -> String
toutils/mod.rs
.LogEntry
.I followed the checklist:
make check
without errors