Skip to content

Issue/768/support markdown emoji #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

andrewpollack
Copy link
Contributor

@andrewpollack andrewpollack commented Aug 21, 2021

Thank you again for the advice on the previous PR! This is helping me learn better Rust coding practices, and I very much appreciate it 😄

This Pull Request fixes/closes #768.

It changes the following:

  • Adds gh-emoji crate to dependencies.
  • Updated changelog with png of change in action.
  • Added new fn emojifi_string(s: &str) -> String to utils/mod.rs.
  • Utilized above function to emojify messages in LogEntry.

I followed the checklist:

  • [:heavy_check_mark: ] I added unittests
  • [:heavy_check_mark: ] I ran make check without errors
  • [:heavy_check_mark: ] I tested the overall application
  • [:heavy_check_mark: ] I added an appropriate item to the changelog

@andrewpollack
Copy link
Contributor Author

My local cargo fmt -- --check fails on this line here https://github.com/extrawurst/gitui/blob/779a811b58a756f0dfcd8358d9a6025219142f77/asyncgit/src/sync/tags.rs#L45 , but when I make the suggested changes, they fail for the linting that's run in the CI/CD here. Any thoughts on what I should do here?

@extrawurst extrawurst self-requested a review August 23, 2021 09:55
@extrawurst extrawurst merged commit d3a6fdd into gitui-org:master Aug 23, 2021
@extrawurst
Copy link
Collaborator

@andrewpollack thanks for your contribution. Checkout d72dcdd To see what I improved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Markdown emoji
2 participants