Skip to content

Popup history #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Popup history #962

wants to merge 2 commits into from

Conversation

R0nd
Copy link
Contributor

@R0nd R0nd commented Oct 24, 2021

This Pull Request fixes/closes #846.

It changes the following:

  • implements popup history

I followed the checklist:

  • I added unittests
  • I ran make check without errors
  • I tested the overall application
  • I added an appropriate item to the changelog

@R0nd
Merge branch 'master'
3351ce5 
Conflicts:
	CHANGELOG.md
@extrawurst
Copy link
Collaborator

the problem with this approach is:

  • The way we open/close popups using channels is not enough: it does not preserve the parameters each popup takes in its open function, which the history might overwrite
  • I am not a fan of the ergonomics, having a channel for each popup

@extrawurst extrawurst marked this pull request as draft January 10, 2022 00:23
@extrawurst
Copy link
Collaborator

closed in favour of #1124

@extrawurst extrawurst closed this Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

popup back button history
2 participants
@R0nd @extrawurst