-
-
Notifications
You must be signed in to change notification settings - Fork 43
Add process names, refocus scope, rework API #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
General note: There's a lot of really good QOL stuff happening in this PR :) |
Made a small PR with some minor docs changes so you don't have to bother copying them over: #72 |
Co-authored-by: Giacomo Cavalieri <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i like these changes. RIP rescue
🙏🏻
Since we're introducing breaking changes, would it make sense to include #67 also? It contains changes from I can rebase it on top of this branch, if it helps. |
Good idea @sbergen! I wonder if there's any further improvements we could make to those types... |
I still find the asymmetry of |
What are some uses you have for decoding the exit reason?
This would mean we have it completely unchecked by the type system, and the programmer just have to get the correct magic values! |
OK, I am convinced @sbergen ! I have merged your changes into this branch. :) |
As a package author, I was thinking of it more as a HTTP 500 (oops, my bad) vs 502 (I can't do my job because of a third party) that could be reported to the user of the package...
...but indeed, this sort of information could be included in strings also. I just like types a lot more than strings :)
I think you could have one typed variant of
|
Co-authored-by: Sakari Bergen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏🏻 extremely excited
Reworking the API of this package for a v1 release! The big new feature is named processes, which will make writing OTP programs much easier in Gleam.