Skip to content

Fixes for alpine 3.16 #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 9, 2022
Merged

Fixes for alpine 3.16 #78

merged 4 commits into from
Dec 9, 2022

Conversation

cedric-anne
Copy link
Member

  1. gnu-libiconv is now installed on base image, no need to install it manually (see Use gnu-libiconv on alpine only for php iconv extension docker-library/php#1264).

  2. ICU data has been splitted in alpine 3.16 and icu-data-full has to be installed to have a support of many charsets (see https://wiki.alpinelinux.org/wiki/Release_Notes_for_Alpine_3.16.0#ICU_data_split). Without this, our test suite fails:

=> tests\units\Toolbox::testFilename():
In file /var/glpi/tests/functionnal/Toolbox.php on line 139, string() failed for data set [7] of data provider filenameProvider: string(8) '24.1.txt' is not identical to string(90) '24.1-zhang-wen-jian-ming-jiang-dao-zhi-nei-rong-chu-zhi-biao-tou-zhong-de-lian-xu-xing.txt'
-Expected
+Actual
@@ -1 +1 @@
-string(90) "24.1-zhang-wen-jian-ming-jiang-dao-zhi-nei-rong-chu-zhi-biao-tou-zhong-de-lian-xu-xing.txt"
+string(8) "24.1.txt"
  1. Some instructions related to PHP 7.4 were still present.

  2. gettext package is up-to-date in alpine 3.16, no need to fetch it from an alternative repository.

@cedric-anne cedric-anne requested a review from trasher December 9, 2022 11:07
@cedric-anne cedric-anne self-assigned this Dec 9, 2022
@cedric-anne cedric-anne merged commit f25b6e5 into master Dec 9, 2022
@cedric-anne cedric-anne deleted the fix/alpine-3.16 branch December 9, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant