Adjust CodeActionResponse #105
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at
textDocument/codeAction
it seems to be returning heterogeneous array(Command | CodeAction)[] | null
rather thanCommand[] | CodeAction[] | null
so I adjusted that accordingly.Discovered this while working on rust-lang/vscode-rust#609 - right now RLS sends only
Vec<Command>
but to fix the issue we also need send someCodeAction
s as well, hence why we need the heterogenous array.r? @Marwes