Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several project setup fixes #1

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

michaelbrooks
Copy link

I ran into several issues getting this to run, so here's what I had to fix:

  • the shell scripts should be forced to LF. I ran this in Vagrant on Windows, so the CRLF endings from my Windows git clone made the script un-runnable in Ubuntu.
  • the README needs to mention installing the python requirements
  • the README refers to start.sh which at some point must have been renamed to just start
  • sample_python_app.py tries to save a config file but was using read mode instead of write
  • the relative path to the log directory is outside the project folder. In Vagrant, for example, this becomes the absolute path /log, which isn't writable.
  • the bootstrap.sh file should use the -y flag when running apt-get. It should also install curl before using curl to install pip.

I wasn't able to actually test whether the program streams data from Gnip correctly because I found out my access doesn't include the streaming APIs, but it at least ran after these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants