Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: GOFF Specificity #11

Merged
merged 7 commits into from
Jul 9, 2024
Merged

feat: GOFF Specificity #11

merged 7 commits into from
Jul 9, 2024

Conversation

thomaspoignant
Copy link
Contributor

@thomaspoignant thomaspoignant commented Jul 7, 2024

Description

  • add test provider name
  • Support flagMetadata
  • Manage the flag data collection

Fixes #6

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have followed the contributing guide

Signed-off-by: Thomas Poignant <[email protected]>
Copy link

codecov bot commented Jul 7, 2024

Codecov Report

Attention: Patch coverage is 80.43912% with 98 lines in your changes missing coverage. Please review.

Project coverage is 84.27%. Comparing base (73c79df) to head (e73f84b).

Files Patch % Lines
Sources/GOFeatureFlag/model/feature_event.swift 0.00% 44 Missing ⚠️
Sources/OFREP/model/bulk_evaluation_response.swift 72.72% 12 Missing ⚠️
Sources/OFREP/ofrep.swift 83.78% 6 Missing ⚠️
Sources/GOFeatureFlag/model/value_extension.swift 72.22% 5 Missing ⚠️
.../GOFeatureFlag/hook/data_collector_bool_hook.swift 90.90% 4 Missing ⚠️
...OFeatureFlag/hook/data_collector_double_hook.swift 90.90% 4 Missing ⚠️
...FeatureFlag/hook/data_collector_integer_hook.swift 90.90% 4 Missing ⚠️
...OFeatureFlag/hook/data_collector_object_hook.swift 91.30% 4 Missing ⚠️
...OFeatureFlag/hook/data_collector_string_hook.swift 90.90% 4 Missing ⚠️
Sources/GOFeatureFlag/provider.swift 91.48% 4 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
+ Coverage   76.95%   84.27%   +7.31%     
==========================================
  Files           9       22      +13     
  Lines         421      865     +444     
==========================================
+ Hits          324      729     +405     
- Misses         97      136      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomaspoignant thomaspoignant merged commit 81dea6d into main Jul 9, 2024
5 checks passed
@thomaspoignant thomaspoignant deleted the goff-specificity branch July 9, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: Add a data collection hook
1 participant