Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Openfeature SDK spec 0.8 support #15

Merged
merged 6 commits into from
Mar 13, 2025
Merged

feat: Openfeature SDK spec 0.8 support #15

merged 6 commits into from
Mar 13, 2025

Conversation

thomaspoignant
Copy link
Contributor

Description

A new version of the Openfeature SDK is ongoing with the support of the v0.8.0 spec.
A pull request is open for this one.

This PR is to be compatible with the latest version of the SDK.

Warning

Before merging this version we need to change the dependency to link to the new version of the SDK (when it is released) and not to the branch as it is now.

Closes issue(s)

Resolve #12

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have followed the contributing guide

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 70.21277% with 14 lines in your changes missing coverage. Please review.

Project coverage is 85.91%. Comparing base (91a9a90) to head (da09493).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
Sources/OFREP/ofrep.swift 70.27% 11 Missing ⚠️
Sources/GOFeatureFlag/provider.swift 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
- Coverage   86.36%   85.91%   -0.45%     
==========================================
  Files          23       23              
  Lines        1144     1143       -1     
==========================================
- Hits          988      982       -6     
- Misses        156      161       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Thomas Poignant <[email protected]>
@thomaspoignant thomaspoignant marked this pull request as draft January 20, 2025 17:34
@thomaspoignant thomaspoignant marked this pull request as ready for review March 13, 2025 14:42
@thomaspoignant thomaspoignant merged commit bd70399 into main Mar 13, 2025
3 of 5 checks passed
@thomaspoignant thomaspoignant deleted the of-spec-0.8 branch March 13, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: return stale reason if provider is not ready
1 participant