Skip to content

Calculate pixel_ratio based on users' display #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2019
Merged

Calculate pixel_ratio based on users' display #75

merged 1 commit into from
Feb 17, 2019

Conversation

GeertJohan
Copy link
Member

No description provided.

@GeertJohan GeertJohan force-pushed the feature/calculate-pixel-ratio branch 2 times, most recently from 2ab53c1 to 12c89b0 Compare February 17, 2019 17:51
@GeertJohan GeertJohan force-pushed the feature/calculate-pixel-ratio branch from 12c89b0 to 8515fb3 Compare February 17, 2019 18:08
GeertJohan
GeertJohan commented Feb 17, 2019
View reviewed changes
gutter.go
width, _ := window.GetSize()
pixelsPerScreenCoordinate := float64(widthPx) / float64(width)
x = x * pixelsPerScreenCoordinate
y = y * pixelsPerScreenCoordinate
Copy link
Member Author

@GeertJohan GeertJohan Feb 17, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GetCursorPos returns the cursor position in screen coordinates, but flutter only knows about the framebuffer sizes and expects the click location to be in pixels.
On most machines the pixel to screen coordinates ratio is 1.0, which is why this bug has probably gone unnoticed so far. This calculation fixes click position for users who have pixelsPerScreenCoordinate != 1.0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification, It was needed 👍

@GeertJohan GeertJohan requested a review from pchampio February 17, 2019 18:12
pchampio
pchampio approved these changes Feb 17, 2019
View reviewed changes
Copy link
Member

@pchampio pchampio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't own a HDPI monitor, I can't test this.
When the pixel ration is 1, everything seems to works fine. Gona trust you

@pchampio pchampio merged commit 62ef42e into go-flutter-desktop:master Feb 17, 2019
zephylac pushed a commit to zephylac/go-flutter that referenced this pull request Jun 6, 2019
@zephylac
Support Chinese URL
232f2e6 
Support Chinese URL (go-flutter-desktop#48)

Fixes go-flutter-desktop#48

Support MacShortcuts

Support quick cursor move

Clarification of the purpose explanation. go-flutter-desktop#54

Fixes go-flutter-desktop#54, confusing README

Update README.md

Fix regression caused by go-flutter-desktop#47

Feature/keyboard layout support (go-flutter-desktop#57)

* Support different layout

* Exported struct, user can use it in main

* Renaming function (matchin new format)

* Added default value for shortcuts

* Removed local import (testing)

* Added keyboard config

* Check for optionnal keyboard

* Fixed renaming

* Fixed regression

* new example for keyboard

* Added explaination

Now only send boolean

Changed to boolean parameter & fixed textSelection

Fixed some issue, added backspace wordTravellerKEy support

wordTravellerKEy added (alt for MacOS, Ctrl for others)

Update BUG.md (go-flutter-desktop#69)

Removes the "task list" from the template.

Add gl_proc_resolver to resolve GL procs within the GLFW context (go-flutter-desktop#71)

Fix two race conditions and a type conversion mistake (go-flutter-desktop#70)

GLFW callbacks: Obtaining the index of the engine using the window userPointer

Engine Args: main_path and packages_path should be set null

Assert that EngineOpenGL was created using NewEngineOpenGL (go-flutter-desktop#73)

Update LICENSE

Calculate pixel_ratio based on users' display (go-flutter-desktop#75)

Update release mode flag

Example: User defined Pixel Ratio

Moved project (go-flutter-desktop#76)

Rename a bunch of things:
- import path github.com/Drakirus/go-flutter-desktop-embedder > github.com/go-flutter-desktop/go-flutter
- package path go-flutter/flutter > go-flutter/embedder
- package name flutter > embedder
- package name gutter > flutter
- embedder.EngineOpenGL > embedder.FlutterEngine
- identifier flutterOGL > flutterEngine
- formatted embedder.embedder_helper.c

README.md: Package rename, change to introduction

Fix Linux control issue

Fixes go-flutter-desktop#79: cgo identifiers conflict

README.md: Add version compatibility information

Deprecate OptionWindowInitializer, add WindowIcon

Update embedder definitions (go-flutter-desktop#81)

updated stocks demo so it work with flutter 1.2.1

Update README.md (go-flutter-desktop#85)

* Update README.md
fixes cd path

Add go.mod

Fix go.mod

Add codecs and a plugin structure, rework the system plugins.

chore: align method receivers

Add debugging values in dpi calculation

README.md: Add godoc and go report card badge

plugin: Add tests

plugin: Add json method codec tests

plugin: Add first method channel tests

chore: Make lint and vet happier and fix spelling mistakes.

chore: Improve identifiers

.github: Update and simplify the issue template

.github: Add template for plugin issues

fixes: gitter link in README.md

chore: adds link to plugins repo

godoc: Handle doc 'MissingPluginException'

Add sane defaults for assets and icudtl

Remove forced pixelratio

Oops, debugging leftover..

Resolve executable path for flutter_assets an icudtl.dat

internal/execpath: cleanup

Improve engine result handling

Add support for sync method handlers

Remove hover desktop setup from example

go.mod: Add test dependencies

Remove duplicate pixels to screencoordinates calculation

Fixes go-flutter-desktop#101

.github: Add example template

Fix broken tests, now using ResponseSender.

README.md: Restructure and simpler getting started

Remove examples

Fix panic and remove glfw dependency from embedder

chore: cleanup and deprecation warnings

Upgrade embedder.h, implement mouse hovering, cleanup glfw cursor handling

embedder: Add README.md

embedder/README.md: cleanup and typo's

Cleanup PointerPhaseNone

Cleanup debug remnant

README.md: Add mouse-over to supported features

Fix go-flutter-desktop#113: Don't double-add event of pointerPhase

embedder: upgrade embedder.h to flutter/engine for v1.5.4-hotfix.2 (52c7a1e849a170be4b2b2fe34142ca2c0a6fea1f)

Implement pointer scrolling.

Fixes go-flutter-desktop#6

Add initial implementation for system navigator pop event (go-flutter-desktop#142)

Unexport PopBehaviorKind

chore: Remove relic of the past

Add WindowMode Option for bordreless and borderless fullscreen windows. (go-flutter-desktop#144)

Add window dimension limits (go-flutter-desktop#145)

* Add window dimensions limits

Add renovate.json

Update github.com/go-gl/glfw commit hash to e6da0ac

pull origin

Revert "pull origin"

This reverts commit 7f1705a.

feature: support for RawKeyboard events

Uses the the RawKeyEventDataLinux for every platform.
RawKeyEventDataLinux is the only Flutter implementation that support the
GLFW Toolkit, the events data is sended as it is, no translation is made
in go-flutter, everything is handled by the Flutter framework.

Update README.md

translate glfw.Repeat to glfw.Press to match other shell's keyevents

fix comment

Removed debug

Removed debug

Renamed var (coded = ☁️ or 😴

New way to handle keyboard

New way to handle keyboard shortcut bind

Fixed masking issue

Fixed masking
zephylac pushed a commit to zephylac/go-flutter that referenced this pull request Jun 6, 2019
@zephylac
Support Chinese URL
3f4ae7c 
Support Chinese URL (go-flutter-desktop#48)

Fixes go-flutter-desktop#48

Support MacShortcuts

Support quick cursor move

Clarification of the purpose explanation. go-flutter-desktop#54

Fixes go-flutter-desktop#54, confusing README

Update README.md

Fix regression caused by go-flutter-desktop#47

Feature/keyboard layout support (go-flutter-desktop#57)

* Support different layout

* Exported struct, user can use it in main

* Renaming function (matchin new format)

* Added default value for shortcuts

* Removed local import (testing)

* Added keyboard config

* Check for optionnal keyboard

* Fixed renaming

* Fixed regression

* new example for keyboard

* Added explaination

Now only send boolean

Changed to boolean parameter & fixed textSelection

Fixed some issue, added backspace wordTravellerKEy support

wordTravellerKEy added (alt for MacOS, Ctrl for others)

Update BUG.md (go-flutter-desktop#69)

Removes the "task list" from the template.

Add gl_proc_resolver to resolve GL procs within the GLFW context (go-flutter-desktop#71)

Fix two race conditions and a type conversion mistake (go-flutter-desktop#70)

GLFW callbacks: Obtaining the index of the engine using the window userPointer

Engine Args: main_path and packages_path should be set null

Assert that EngineOpenGL was created using NewEngineOpenGL (go-flutter-desktop#73)

Update LICENSE

Calculate pixel_ratio based on users' display (go-flutter-desktop#75)

Update release mode flag

Example: User defined Pixel Ratio

Moved project (go-flutter-desktop#76)

Rename a bunch of things:
- import path github.com/Drakirus/go-flutter-desktop-embedder > github.com/go-flutter-desktop/go-flutter
- package path go-flutter/flutter > go-flutter/embedder
- package name flutter > embedder
- package name gutter > flutter
- embedder.EngineOpenGL > embedder.FlutterEngine
- identifier flutterOGL > flutterEngine
- formatted embedder.embedder_helper.c

README.md: Package rename, change to introduction

Fix Linux control issue

Fixes go-flutter-desktop#79: cgo identifiers conflict

README.md: Add version compatibility information

Deprecate OptionWindowInitializer, add WindowIcon

Update embedder definitions (go-flutter-desktop#81)

updated stocks demo so it work with flutter 1.2.1

Update README.md (go-flutter-desktop#85)

* Update README.md
fixes cd path

Add go.mod

Fix go.mod

Add codecs and a plugin structure, rework the system plugins.

chore: align method receivers

Add debugging values in dpi calculation

README.md: Add godoc and go report card badge

plugin: Add tests

plugin: Add json method codec tests

plugin: Add first method channel tests

chore: Make lint and vet happier and fix spelling mistakes.

chore: Improve identifiers

.github: Update and simplify the issue template

.github: Add template for plugin issues

fixes: gitter link in README.md

chore: adds link to plugins repo

godoc: Handle doc 'MissingPluginException'

Add sane defaults for assets and icudtl

Remove forced pixelratio

Oops, debugging leftover..

Resolve executable path for flutter_assets an icudtl.dat

internal/execpath: cleanup

Improve engine result handling

Add support for sync method handlers

Remove hover desktop setup from example

go.mod: Add test dependencies

Remove duplicate pixels to screencoordinates calculation

Fixes go-flutter-desktop#101

.github: Add example template

Fix broken tests, now using ResponseSender.

README.md: Restructure and simpler getting started

Remove examples

Fix panic and remove glfw dependency from embedder

chore: cleanup and deprecation warnings

Upgrade embedder.h, implement mouse hovering, cleanup glfw cursor handling

embedder: Add README.md

embedder/README.md: cleanup and typo's

Cleanup PointerPhaseNone

Cleanup debug remnant

README.md: Add mouse-over to supported features

Fix go-flutter-desktop#113: Don't double-add event of pointerPhase

embedder: upgrade embedder.h to flutter/engine for v1.5.4-hotfix.2 (52c7a1e849a170be4b2b2fe34142ca2c0a6fea1f)

Implement pointer scrolling.

Fixes go-flutter-desktop#6

Add initial implementation for system navigator pop event (go-flutter-desktop#142)

Unexport PopBehaviorKind

chore: Remove relic of the past

Add WindowMode Option for bordreless and borderless fullscreen windows. (go-flutter-desktop#144)

Add window dimension limits (go-flutter-desktop#145)

* Add window dimensions limits

Add renovate.json

Update github.com/go-gl/glfw commit hash to e6da0ac

pull origin

Revert "pull origin"

This reverts commit 7f1705a.

feature: support for RawKeyboard events

Uses the the RawKeyEventDataLinux for every platform.
RawKeyEventDataLinux is the only Flutter implementation that support the
GLFW Toolkit, the events data is sended as it is, no translation is made
in go-flutter, everything is handled by the Flutter framework.

Update README.md

translate glfw.Repeat to glfw.Press to match other shell's keyevents

fix comment

Removed debug

Removed debug

Renamed var (coded = ☁️ or 😴

New way to handle keyboard

New way to handle keyboard shortcut bind

Fixed masking issue

Fixed masking
zephylac pushed a commit to zephylac/go-flutter that referenced this pull request Jun 11, 2019
@zephylac
Support Chinese URL
a34f654 
Support Chinese URL (go-flutter-desktop#48)

Fixes go-flutter-desktop#48

Support MacShortcuts

Support quick cursor move

Clarification of the purpose explanation. go-flutter-desktop#54

Fixes go-flutter-desktop#54, confusing README

Update README.md

Fix regression caused by go-flutter-desktop#47

Feature/keyboard layout support (go-flutter-desktop#57)

* Support different layout

* Exported struct, user can use it in main

* Renaming function (matchin new format)

* Added default value for shortcuts

* Removed local import (testing)

* Added keyboard config

* Check for optionnal keyboard

* Fixed renaming

* Fixed regression

* new example for keyboard

* Added explaination

Now only send boolean

Changed to boolean parameter & fixed textSelection

Fixed some issue, added backspace wordTravellerKEy support

wordTravellerKEy added (alt for MacOS, Ctrl for others)

Update BUG.md (go-flutter-desktop#69)

Removes the "task list" from the template.

Add gl_proc_resolver to resolve GL procs within the GLFW context (go-flutter-desktop#71)

Fix two race conditions and a type conversion mistake (go-flutter-desktop#70)

GLFW callbacks: Obtaining the index of the engine using the window userPointer

Engine Args: main_path and packages_path should be set null

Assert that EngineOpenGL was created using NewEngineOpenGL (go-flutter-desktop#73)

Update LICENSE

Calculate pixel_ratio based on users' display (go-flutter-desktop#75)

Update release mode flag

Example: User defined Pixel Ratio

Moved project (go-flutter-desktop#76)

Rename a bunch of things:
- import path github.com/Drakirus/go-flutter-desktop-embedder > github.com/go-flutter-desktop/go-flutter
- package path go-flutter/flutter > go-flutter/embedder
- package name flutter > embedder
- package name gutter > flutter
- embedder.EngineOpenGL > embedder.FlutterEngine
- identifier flutterOGL > flutterEngine
- formatted embedder.embedder_helper.c

README.md: Package rename, change to introduction

Fix Linux control issue

Fixes go-flutter-desktop#79: cgo identifiers conflict

README.md: Add version compatibility information

Deprecate OptionWindowInitializer, add WindowIcon

Update embedder definitions (go-flutter-desktop#81)

updated stocks demo so it work with flutter 1.2.1

Update README.md (go-flutter-desktop#85)

* Update README.md
fixes cd path

Add go.mod

Fix go.mod

Add codecs and a plugin structure, rework the system plugins.

chore: align method receivers

Add debugging values in dpi calculation

README.md: Add godoc and go report card badge

plugin: Add tests

plugin: Add json method codec tests

plugin: Add first method channel tests

chore: Make lint and vet happier and fix spelling mistakes.

chore: Improve identifiers

.github: Update and simplify the issue template

.github: Add template for plugin issues

fixes: gitter link in README.md

chore: adds link to plugins repo

godoc: Handle doc 'MissingPluginException'

Add sane defaults for assets and icudtl

Remove forced pixelratio

Oops, debugging leftover..

Resolve executable path for flutter_assets an icudtl.dat

internal/execpath: cleanup

Improve engine result handling

Add support for sync method handlers

Remove hover desktop setup from example

go.mod: Add test dependencies

Remove duplicate pixels to screencoordinates calculation

Fixes go-flutter-desktop#101

.github: Add example template

Fix broken tests, now using ResponseSender.

README.md: Restructure and simpler getting started

Remove examples

Fix panic and remove glfw dependency from embedder

chore: cleanup and deprecation warnings

Upgrade embedder.h, implement mouse hovering, cleanup glfw cursor handling

embedder: Add README.md

embedder/README.md: cleanup and typo's

Cleanup PointerPhaseNone

Cleanup debug remnant

README.md: Add mouse-over to supported features

Fix go-flutter-desktop#113: Don't double-add event of pointerPhase

embedder: upgrade embedder.h to flutter/engine for v1.5.4-hotfix.2 (52c7a1e849a170be4b2b2fe34142ca2c0a6fea1f)

Implement pointer scrolling.

Fixes go-flutter-desktop#6

Add initial implementation for system navigator pop event (go-flutter-desktop#142)

Unexport PopBehaviorKind

chore: Remove relic of the past

Add WindowMode Option for bordreless and borderless fullscreen windows. (go-flutter-desktop#144)

Add window dimension limits (go-flutter-desktop#145)

* Add window dimensions limits

Add renovate.json

Update github.com/go-gl/glfw commit hash to e6da0ac

pull origin

Revert "pull origin"

This reverts commit 7f1705a.

feature: support for RawKeyboard events

Uses the the RawKeyEventDataLinux for every platform.
RawKeyEventDataLinux is the only Flutter implementation that support the
GLFW Toolkit, the events data is sended as it is, no translation is made
in go-flutter, everything is handled by the Flutter framework.

Update README.md

translate glfw.Repeat to glfw.Press to match other shell's keyevents

fix comment

Removed debug

Removed debug

Renamed var (coded = ☁️ or 😴

New way to handle keyboard

New way to handle keyboard shortcut bind

Fixed masking issue

Fixed masking
zephylac pushed a commit to zephylac/go-flutter that referenced this pull request Jun 11, 2019
@zephylac
Support Chinese URL
cc4ebcf 
Support Chinese URL (go-flutter-desktop#48)

Fixes go-flutter-desktop#48

Support MacShortcuts

Support quick cursor move

Clarification of the purpose explanation. go-flutter-desktop#54

Fixes go-flutter-desktop#54, confusing README

Update README.md

Fix regression caused by go-flutter-desktop#47

Feature/keyboard layout support (go-flutter-desktop#57)

* Support different layout

* Exported struct, user can use it in main

* Renaming function (matchin new format)

* Added default value for shortcuts

* Removed local import (testing)

* Added keyboard config

* Check for optionnal keyboard

* Fixed renaming

* Fixed regression

* new example for keyboard

* Added explaination

Now only send boolean

Changed to boolean parameter & fixed textSelection

Fixed some issue, added backspace wordTravellerKEy support

wordTravellerKEy added (alt for MacOS, Ctrl for others)

Update BUG.md (go-flutter-desktop#69)

Removes the "task list" from the template.

Add gl_proc_resolver to resolve GL procs within the GLFW context (go-flutter-desktop#71)

Fix two race conditions and a type conversion mistake (go-flutter-desktop#70)

GLFW callbacks: Obtaining the index of the engine using the window userPointer

Engine Args: main_path and packages_path should be set null

Assert that EngineOpenGL was created using NewEngineOpenGL (go-flutter-desktop#73)

Update LICENSE

Calculate pixel_ratio based on users' display (go-flutter-desktop#75)

Update release mode flag

Example: User defined Pixel Ratio

Moved project (go-flutter-desktop#76)

Rename a bunch of things:
- import path github.com/Drakirus/go-flutter-desktop-embedder > github.com/go-flutter-desktop/go-flutter
- package path go-flutter/flutter > go-flutter/embedder
- package name flutter > embedder
- package name gutter > flutter
- embedder.EngineOpenGL > embedder.FlutterEngine
- identifier flutterOGL > flutterEngine
- formatted embedder.embedder_helper.c

README.md: Package rename, change to introduction

Fix Linux control issue

Fixes go-flutter-desktop#79: cgo identifiers conflict

README.md: Add version compatibility information

Deprecate OptionWindowInitializer, add WindowIcon

Update embedder definitions (go-flutter-desktop#81)

updated stocks demo so it work with flutter 1.2.1

Update README.md (go-flutter-desktop#85)

* Update README.md
fixes cd path

Add go.mod

Fix go.mod

Add codecs and a plugin structure, rework the system plugins.

chore: align method receivers

Add debugging values in dpi calculation

README.md: Add godoc and go report card badge

plugin: Add tests

plugin: Add json method codec tests

plugin: Add first method channel tests

chore: Make lint and vet happier and fix spelling mistakes.

chore: Improve identifiers

.github: Update and simplify the issue template

.github: Add template for plugin issues

fixes: gitter link in README.md

chore: adds link to plugins repo

godoc: Handle doc 'MissingPluginException'

Add sane defaults for assets and icudtl

Remove forced pixelratio

Oops, debugging leftover..

Resolve executable path for flutter_assets an icudtl.dat

internal/execpath: cleanup

Improve engine result handling

Add support for sync method handlers

Remove hover desktop setup from example

go.mod: Add test dependencies

Remove duplicate pixels to screencoordinates calculation

Fixes go-flutter-desktop#101

.github: Add example template

Fix broken tests, now using ResponseSender.

README.md: Restructure and simpler getting started

Remove examples

Fix panic and remove glfw dependency from embedder

chore: cleanup and deprecation warnings

Upgrade embedder.h, implement mouse hovering, cleanup glfw cursor handling

embedder: Add README.md

embedder/README.md: cleanup and typo's

Cleanup PointerPhaseNone

Cleanup debug remnant

README.md: Add mouse-over to supported features

Fix go-flutter-desktop#113: Don't double-add event of pointerPhase

embedder: upgrade embedder.h to flutter/engine for v1.5.4-hotfix.2 (52c7a1e849a170be4b2b2fe34142ca2c0a6fea1f)

Implement pointer scrolling.

Fixes go-flutter-desktop#6

Add initial implementation for system navigator pop event (go-flutter-desktop#142)

Unexport PopBehaviorKind

chore: Remove relic of the past

Add WindowMode Option for bordreless and borderless fullscreen windows. (go-flutter-desktop#144)

Add window dimension limits (go-flutter-desktop#145)

* Add window dimensions limits

Add renovate.json

Update github.com/go-gl/glfw commit hash to e6da0ac

pull origin

Revert "pull origin"

This reverts commit 7f1705a.

feature: support for RawKeyboard events

Uses the the RawKeyEventDataLinux for every platform.
RawKeyEventDataLinux is the only Flutter implementation that support the
GLFW Toolkit, the events data is sended as it is, no translation is made
in go-flutter, everything is handled by the Flutter framework.

Update README.md

translate glfw.Repeat to glfw.Press to match other shell's keyevents

fix comment

Removed debug

Removed debug

Renamed var (coded = ☁️ or 😴

New way to handle keyboard

New way to handle keyboard shortcut bind

Fixed masking issue

Fixed masking
zephylac pushed a commit to zephylac/go-flutter that referenced this pull request Jun 11, 2019
@zephylac
Support Chinese URL
b5a8a1c 
Support Chinese URL (go-flutter-desktop#48)

Fixes go-flutter-desktop#48

Support MacShortcuts

Support quick cursor move

Clarification of the purpose explanation. go-flutter-desktop#54

Fixes go-flutter-desktop#54, confusing README

Update README.md

Fix regression caused by go-flutter-desktop#47

Feature/keyboard layout support (go-flutter-desktop#57)

* Support different layout

* Exported struct, user can use it in main

* Renaming function (matchin new format)

* Added default value for shortcuts

* Removed local import (testing)

* Added keyboard config

* Check for optionnal keyboard

* Fixed renaming

* Fixed regression

* new example for keyboard

* Added explaination

Now only send boolean

Changed to boolean parameter & fixed textSelection

Fixed some issue, added backspace wordTravellerKEy support

wordTravellerKEy added (alt for MacOS, Ctrl for others)

Update BUG.md (go-flutter-desktop#69)

Removes the "task list" from the template.

Add gl_proc_resolver to resolve GL procs within the GLFW context (go-flutter-desktop#71)

Fix two race conditions and a type conversion mistake (go-flutter-desktop#70)

GLFW callbacks: Obtaining the index of the engine using the window userPointer

Engine Args: main_path and packages_path should be set null

Assert that EngineOpenGL was created using NewEngineOpenGL (go-flutter-desktop#73)

Update LICENSE

Calculate pixel_ratio based on users' display (go-flutter-desktop#75)

Update release mode flag

Example: User defined Pixel Ratio

Moved project (go-flutter-desktop#76)

Rename a bunch of things:
- import path github.com/Drakirus/go-flutter-desktop-embedder > github.com/go-flutter-desktop/go-flutter
- package path go-flutter/flutter > go-flutter/embedder
- package name flutter > embedder
- package name gutter > flutter
- embedder.EngineOpenGL > embedder.FlutterEngine
- identifier flutterOGL > flutterEngine
- formatted embedder.embedder_helper.c

README.md: Package rename, change to introduction

Fix Linux control issue

Fixes go-flutter-desktop#79: cgo identifiers conflict

README.md: Add version compatibility information

Deprecate OptionWindowInitializer, add WindowIcon

Update embedder definitions (go-flutter-desktop#81)

updated stocks demo so it work with flutter 1.2.1

Update README.md (go-flutter-desktop#85)

* Update README.md
fixes cd path

Add go.mod

Fix go.mod

Add codecs and a plugin structure, rework the system plugins.

chore: align method receivers

Add debugging values in dpi calculation

README.md: Add godoc and go report card badge

plugin: Add tests

plugin: Add json method codec tests

plugin: Add first method channel tests

chore: Make lint and vet happier and fix spelling mistakes.

chore: Improve identifiers

.github: Update and simplify the issue template

.github: Add template for plugin issues

fixes: gitter link in README.md

chore: adds link to plugins repo

godoc: Handle doc 'MissingPluginException'

Add sane defaults for assets and icudtl

Remove forced pixelratio

Oops, debugging leftover..

Resolve executable path for flutter_assets an icudtl.dat

internal/execpath: cleanup

Improve engine result handling

Add support for sync method handlers

Remove hover desktop setup from example

go.mod: Add test dependencies

Remove duplicate pixels to screencoordinates calculation

Fixes go-flutter-desktop#101

.github: Add example template

Fix broken tests, now using ResponseSender.

README.md: Restructure and simpler getting started

Remove examples

Fix panic and remove glfw dependency from embedder

chore: cleanup and deprecation warnings

Upgrade embedder.h, implement mouse hovering, cleanup glfw cursor handling

embedder: Add README.md

embedder/README.md: cleanup and typo's

Cleanup PointerPhaseNone

Cleanup debug remnant

README.md: Add mouse-over to supported features

Fix go-flutter-desktop#113: Don't double-add event of pointerPhase

embedder: upgrade embedder.h to flutter/engine for v1.5.4-hotfix.2 (52c7a1e849a170be4b2b2fe34142ca2c0a6fea1f)

Implement pointer scrolling.

Fixes go-flutter-desktop#6

Add initial implementation for system navigator pop event (go-flutter-desktop#142)

Unexport PopBehaviorKind

chore: Remove relic of the past

Add WindowMode Option for bordreless and borderless fullscreen windows. (go-flutter-desktop#144)

Add window dimension limits (go-flutter-desktop#145)

* Add window dimensions limits

Add renovate.json

Update github.com/go-gl/glfw commit hash to e6da0ac

pull origin

Revert "pull origin"

This reverts commit 7f1705a.

feature: support for RawKeyboard events

Uses the the RawKeyEventDataLinux for every platform.
RawKeyEventDataLinux is the only Flutter implementation that support the
GLFW Toolkit, the events data is sended as it is, no translation is made
in go-flutter, everything is handled by the Flutter framework.

Update README.md

translate glfw.Repeat to glfw.Press to match other shell's keyevents

fix comment

Removed debug

Removed debug

Renamed var (coded = ☁️ or 😴

New way to handle keyboard

New way to handle keyboard shortcut bind

Fixed masking issue

Fixed masking
zephylac pushed a commit to zephylac/go-flutter that referenced this pull request Jun 17, 2019
@zephylac
Support Chinese URL
6e4f0c3 
Support Chinese URL (go-flutter-desktop#48)

Fixes go-flutter-desktop#48

Support MacShortcuts

Support quick cursor move

Clarification of the purpose explanation. go-flutter-desktop#54

Fixes go-flutter-desktop#54, confusing README

Update README.md

Fix regression caused by go-flutter-desktop#47

Feature/keyboard layout support (go-flutter-desktop#57)

* Support different layout

* Exported struct, user can use it in main

* Renaming function (matchin new format)

* Added default value for shortcuts

* Removed local import (testing)

* Added keyboard config

* Check for optionnal keyboard

* Fixed renaming

* Fixed regression

* new example for keyboard

* Added explaination

Now only send boolean

Changed to boolean parameter & fixed textSelection

Fixed some issue, added backspace wordTravellerKEy support

wordTravellerKEy added (alt for MacOS, Ctrl for others)

Update BUG.md (go-flutter-desktop#69)

Removes the "task list" from the template.

Add gl_proc_resolver to resolve GL procs within the GLFW context (go-flutter-desktop#71)

Fix two race conditions and a type conversion mistake (go-flutter-desktop#70)

GLFW callbacks: Obtaining the index of the engine using the window userPointer

Engine Args: main_path and packages_path should be set null

Assert that EngineOpenGL was created using NewEngineOpenGL (go-flutter-desktop#73)

Update LICENSE

Calculate pixel_ratio based on users' display (go-flutter-desktop#75)

Update release mode flag

Example: User defined Pixel Ratio

Moved project (go-flutter-desktop#76)

Rename a bunch of things:
- import path github.com/Drakirus/go-flutter-desktop-embedder > github.com/go-flutter-desktop/go-flutter
- package path go-flutter/flutter > go-flutter/embedder
- package name flutter > embedder
- package name gutter > flutter
- embedder.EngineOpenGL > embedder.FlutterEngine
- identifier flutterOGL > flutterEngine
- formatted embedder.embedder_helper.c

README.md: Package rename, change to introduction

Fix Linux control issue

Fixes go-flutter-desktop#79: cgo identifiers conflict

README.md: Add version compatibility information

Deprecate OptionWindowInitializer, add WindowIcon

Update embedder definitions (go-flutter-desktop#81)

updated stocks demo so it work with flutter 1.2.1

Update README.md (go-flutter-desktop#85)

* Update README.md
fixes cd path

Add go.mod

Fix go.mod

Add codecs and a plugin structure, rework the system plugins.

chore: align method receivers

Add debugging values in dpi calculation

README.md: Add godoc and go report card badge

plugin: Add tests

plugin: Add json method codec tests

plugin: Add first method channel tests

chore: Make lint and vet happier and fix spelling mistakes.

chore: Improve identifiers

.github: Update and simplify the issue template

.github: Add template for plugin issues

fixes: gitter link in README.md

chore: adds link to plugins repo

godoc: Handle doc 'MissingPluginException'

Add sane defaults for assets and icudtl

Remove forced pixelratio

Oops, debugging leftover..

Resolve executable path for flutter_assets an icudtl.dat

internal/execpath: cleanup

Improve engine result handling

Add support for sync method handlers

Remove hover desktop setup from example

go.mod: Add test dependencies

Remove duplicate pixels to screencoordinates calculation

Fixes go-flutter-desktop#101

.github: Add example template

Fix broken tests, now using ResponseSender.

README.md: Restructure and simpler getting started

Remove examples

Fix panic and remove glfw dependency from embedder

chore: cleanup and deprecation warnings

Upgrade embedder.h, implement mouse hovering, cleanup glfw cursor handling

embedder: Add README.md

embedder/README.md: cleanup and typo's

Cleanup PointerPhaseNone

Cleanup debug remnant

README.md: Add mouse-over to supported features

Fix go-flutter-desktop#113: Don't double-add event of pointerPhase

embedder: upgrade embedder.h to flutter/engine for v1.5.4-hotfix.2 (52c7a1e849a170be4b2b2fe34142ca2c0a6fea1f)

Implement pointer scrolling.

Fixes go-flutter-desktop#6

Add initial implementation for system navigator pop event (go-flutter-desktop#142)

Unexport PopBehaviorKind

chore: Remove relic of the past

Add WindowMode Option for bordreless and borderless fullscreen windows. (go-flutter-desktop#144)

Add window dimension limits (go-flutter-desktop#145)

* Add window dimensions limits

Add renovate.json

Update github.com/go-gl/glfw commit hash to e6da0ac

pull origin

Revert "pull origin"

This reverts commit 7f1705a.

feature: support for RawKeyboard events

Uses the the RawKeyEventDataLinux for every platform.
RawKeyEventDataLinux is the only Flutter implementation that support the
GLFW Toolkit, the events data is sended as it is, no translation is made
in go-flutter, everything is handled by the Flutter framework.

Update README.md

translate glfw.Repeat to glfw.Press to match other shell's keyevents

fix comment

Removed debug

Removed debug

Renamed var (coded = ☁️ or 😴

New way to handle keyboard

New way to handle keyboard shortcut bind

Fixed masking issue

Fixed masking
zephylac pushed a commit to zephylac/go-flutter that referenced this pull request Jul 3, 2019
@zephylac
Support Chinese URL
1e0225c 
Support Chinese URL (go-flutter-desktop#48)

Fixes go-flutter-desktop#48

Support MacShortcuts

Support quick cursor move

Clarification of the purpose explanation. go-flutter-desktop#54

Fixes go-flutter-desktop#54, confusing README

Update README.md

Fix regression caused by go-flutter-desktop#47

Feature/keyboard layout support (go-flutter-desktop#57)

* Support different layout

* Exported struct, user can use it in main

* Renaming function (matchin new format)

* Added default value for shortcuts

* Removed local import (testing)

* Added keyboard config

* Check for optionnal keyboard

* Fixed renaming

* Fixed regression

* new example for keyboard

* Added explaination

Now only send boolean

Changed to boolean parameter & fixed textSelection

Fixed some issue, added backspace wordTravellerKEy support

wordTravellerKEy added (alt for MacOS, Ctrl for others)

Update BUG.md (go-flutter-desktop#69)

Removes the "task list" from the template.

Add gl_proc_resolver to resolve GL procs within the GLFW context (go-flutter-desktop#71)

Fix two race conditions and a type conversion mistake (go-flutter-desktop#70)

GLFW callbacks: Obtaining the index of the engine using the window userPointer

Engine Args: main_path and packages_path should be set null

Assert that EngineOpenGL was created using NewEngineOpenGL (go-flutter-desktop#73)

Update LICENSE

Calculate pixel_ratio based on users' display (go-flutter-desktop#75)

Update release mode flag

Example: User defined Pixel Ratio

Moved project (go-flutter-desktop#76)

Rename a bunch of things:
- import path github.com/Drakirus/go-flutter-desktop-embedder > github.com/go-flutter-desktop/go-flutter
- package path go-flutter/flutter > go-flutter/embedder
- package name flutter > embedder
- package name gutter > flutter
- embedder.EngineOpenGL > embedder.FlutterEngine
- identifier flutterOGL > flutterEngine
- formatted embedder.embedder_helper.c

README.md: Package rename, change to introduction

Fix Linux control issue

Fixes go-flutter-desktop#79: cgo identifiers conflict

README.md: Add version compatibility information

Deprecate OptionWindowInitializer, add WindowIcon

Update embedder definitions (go-flutter-desktop#81)

updated stocks demo so it work with flutter 1.2.1

Update README.md (go-flutter-desktop#85)

* Update README.md
fixes cd path

Add go.mod

Fix go.mod

Add codecs and a plugin structure, rework the system plugins.

chore: align method receivers

Add debugging values in dpi calculation

README.md: Add godoc and go report card badge

plugin: Add tests

plugin: Add json method codec tests

plugin: Add first method channel tests

chore: Make lint and vet happier and fix spelling mistakes.

chore: Improve identifiers

.github: Update and simplify the issue template

.github: Add template for plugin issues

fixes: gitter link in README.md

chore: adds link to plugins repo

godoc: Handle doc 'MissingPluginException'

Add sane defaults for assets and icudtl

Remove forced pixelratio

Oops, debugging leftover..

Resolve executable path for flutter_assets an icudtl.dat

internal/execpath: cleanup

Improve engine result handling

Add support for sync method handlers

Remove hover desktop setup from example

go.mod: Add test dependencies

Remove duplicate pixels to screencoordinates calculation

Fixes go-flutter-desktop#101

.github: Add example template

Fix broken tests, now using ResponseSender.

README.md: Restructure and simpler getting started

Remove examples

Fix panic and remove glfw dependency from embedder

chore: cleanup and deprecation warnings

Upgrade embedder.h, implement mouse hovering, cleanup glfw cursor handling

embedder: Add README.md

embedder/README.md: cleanup and typo's

Cleanup PointerPhaseNone

Cleanup debug remnant

README.md: Add mouse-over to supported features

Fix go-flutter-desktop#113: Don't double-add event of pointerPhase

embedder: upgrade embedder.h to flutter/engine for v1.5.4-hotfix.2 (52c7a1e849a170be4b2b2fe34142ca2c0a6fea1f)

Implement pointer scrolling.

Fixes go-flutter-desktop#6

Add initial implementation for system navigator pop event (go-flutter-desktop#142)

Unexport PopBehaviorKind

chore: Remove relic of the past

Add WindowMode Option for bordreless and borderless fullscreen windows. (go-flutter-desktop#144)

Add window dimension limits (go-flutter-desktop#145)

* Add window dimensions limits

Add renovate.json

Update github.com/go-gl/glfw commit hash to e6da0ac

pull origin

Revert "pull origin"

This reverts commit 7f1705a.

feature: support for RawKeyboard events

Uses the the RawKeyEventDataLinux for every platform.
RawKeyEventDataLinux is the only Flutter implementation that support the
GLFW Toolkit, the events data is sended as it is, no translation is made
in go-flutter, everything is handled by the Flutter framework.

Update README.md

translate glfw.Repeat to glfw.Press to match other shell's keyevents

fix comment

Removed debug

Removed debug

Renamed var (coded = ☁️ or 😴

New way to handle keyboard

New way to handle keyboard shortcut bind

Fixed masking issue

Fixed masking
zephylac pushed a commit to zephylac/go-flutter that referenced this pull request Jul 3, 2019
@zephylac
Support Chinese URL
91ac5e3 
Support Chinese URL (go-flutter-desktop#48)

Fixes go-flutter-desktop#48

Support MacShortcuts

Support quick cursor move

Clarification of the purpose explanation. go-flutter-desktop#54

Fixes go-flutter-desktop#54, confusing README

Update README.md

Fix regression caused by go-flutter-desktop#47

Feature/keyboard layout support (go-flutter-desktop#57)

* Support different layout

* Exported struct, user can use it in main

* Renaming function (matchin new format)

* Added default value for shortcuts

* Removed local import (testing)

* Added keyboard config

* Check for optionnal keyboard

* Fixed renaming

* Fixed regression

* new example for keyboard

* Added explaination

Now only send boolean

Changed to boolean parameter & fixed textSelection

Fixed some issue, added backspace wordTravellerKEy support

wordTravellerKEy added (alt for MacOS, Ctrl for others)

Update BUG.md (go-flutter-desktop#69)

Removes the "task list" from the template.

Add gl_proc_resolver to resolve GL procs within the GLFW context (go-flutter-desktop#71)

Fix two race conditions and a type conversion mistake (go-flutter-desktop#70)

GLFW callbacks: Obtaining the index of the engine using the window userPointer

Engine Args: main_path and packages_path should be set null

Assert that EngineOpenGL was created using NewEngineOpenGL (go-flutter-desktop#73)

Update LICENSE

Calculate pixel_ratio based on users' display (go-flutter-desktop#75)

Update release mode flag

Example: User defined Pixel Ratio

Moved project (go-flutter-desktop#76)

Rename a bunch of things:
- import path github.com/Drakirus/go-flutter-desktop-embedder > github.com/go-flutter-desktop/go-flutter
- package path go-flutter/flutter > go-flutter/embedder
- package name flutter > embedder
- package name gutter > flutter
- embedder.EngineOpenGL > embedder.FlutterEngine
- identifier flutterOGL > flutterEngine
- formatted embedder.embedder_helper.c

README.md: Package rename, change to introduction

Fix Linux control issue

Fixes go-flutter-desktop#79: cgo identifiers conflict

README.md: Add version compatibility information

Deprecate OptionWindowInitializer, add WindowIcon

Update embedder definitions (go-flutter-desktop#81)

updated stocks demo so it work with flutter 1.2.1

Update README.md (go-flutter-desktop#85)

* Update README.md
fixes cd path

Add go.mod

Fix go.mod

Add codecs and a plugin structure, rework the system plugins.

chore: align method receivers

Add debugging values in dpi calculation

README.md: Add godoc and go report card badge

plugin: Add tests

plugin: Add json method codec tests

plugin: Add first method channel tests

chore: Make lint and vet happier and fix spelling mistakes.

chore: Improve identifiers

.github: Update and simplify the issue template

.github: Add template for plugin issues

fixes: gitter link in README.md

chore: adds link to plugins repo

godoc: Handle doc 'MissingPluginException'

Add sane defaults for assets and icudtl

Remove forced pixelratio

Oops, debugging leftover..

Resolve executable path for flutter_assets an icudtl.dat

internal/execpath: cleanup

Improve engine result handling

Add support for sync method handlers

Remove hover desktop setup from example

go.mod: Add test dependencies

Remove duplicate pixels to screencoordinates calculation

Fixes go-flutter-desktop#101

.github: Add example template

Fix broken tests, now using ResponseSender.

README.md: Restructure and simpler getting started

Remove examples

Fix panic and remove glfw dependency from embedder

chore: cleanup and deprecation warnings

Upgrade embedder.h, implement mouse hovering, cleanup glfw cursor handling

embedder: Add README.md

embedder/README.md: cleanup and typo's

Cleanup PointerPhaseNone

Cleanup debug remnant

README.md: Add mouse-over to supported features

Fix go-flutter-desktop#113: Don't double-add event of pointerPhase

embedder: upgrade embedder.h to flutter/engine for v1.5.4-hotfix.2 (52c7a1e849a170be4b2b2fe34142ca2c0a6fea1f)

Implement pointer scrolling.

Fixes go-flutter-desktop#6

Add initial implementation for system navigator pop event (go-flutter-desktop#142)

Unexport PopBehaviorKind

chore: Remove relic of the past

Add WindowMode Option for bordreless and borderless fullscreen windows. (go-flutter-desktop#144)

Add window dimension limits (go-flutter-desktop#145)

* Add window dimensions limits

Add renovate.json

Update github.com/go-gl/glfw commit hash to e6da0ac

pull origin

Revert "pull origin"

This reverts commit 7f1705a.

feature: support for RawKeyboard events

Uses the the RawKeyEventDataLinux for every platform.
RawKeyEventDataLinux is the only Flutter implementation that support the
GLFW Toolkit, the events data is sended as it is, no translation is made
in go-flutter, everything is handled by the Flutter framework.

Update README.md

translate glfw.Repeat to glfw.Press to match other shell's keyevents

fix comment

Removed debug

Removed debug

Renamed var (coded = ☁️ or 😴

New way to handle keyboard

New way to handle keyboard shortcut bind

Fixed masking issue

Fixed masking
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchampio pchampio pchampio approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GeertJohan @pchampio