fixes crash when editing input fields #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- prefix text input methods uniformly. - use a switch statement for selecting method behaviour. - fix crashes in text input by properly setting initial position of the cursor.
james-lawrence
commented
Sep 13, 2018
| @@ -15,9 +15,9 @@ const ( | |||
| TextUpdateStateMethod = "TextInputClient.updateEditingState" | |||
|
|
|||
| // text | |||
| SetClientMethod = "TextInput.setClient" | |||
There was a problem hiding this comment.
should add a updateState method to textModel and handle all these methods in there.
james-lawrence
commented
Sep 13, 2018
| } | ||
|
|
||
| if message.Method == flutter.SetClientMethod { | ||
| case flutter.TextInputClientSet: | ||
| var body []interface{} | ||
| json.Unmarshal(message.Args, &body) | ||
| state.clientID = body[0].(float64) |
There was a problem hiding this comment.
facepalm why couldn't they just include the ID in the initial structure? lol
james-lawrence
commented
Sep 13, 2018
| } | ||
|
|
||
| if message.Method == flutter.SetEditingStateMethod { | ||
| case flutter.TextInputSetEditState: | ||
| if state.clientID != 0 { |
There was a problem hiding this comment.
not sure this check is strictly necessary. but left it in anyways.
|
It does fix #6 👍 |
pchampio
pushed a commit
that referenced
this pull request
Sep 13, 2018
…ial-position fixes crash when editing input fields Former-commit-id: b6345d2
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
position of the cursor.
may fix #6, I didn't notice any issues with multiple text inputs. however I did notice issues when hitting backspace or inserting text. backspace would crash, and text inserts would be in the incorrect position.