osfs: update defaultDirectoryMode to respect umask when creating directories #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjbgf
reviewed
Jan 15, 2025
| @@ -14,7 +14,7 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| defaultDirectoryMode = 0o755 | |||
There was a problem hiding this comment.
Please add some tests to confirm the new behaviour - so that we don't have a regression in the future.
0xDEC0DE
added a commit
to 0xDEC0DE/go-billy
that referenced
this pull request
Apr 9, 2025
a reprise of go-git#104, with added tests The tests for `ChrootFS` do not work with a memfs backend, because memfs creates parent directories with bonkers permissions. drive-by: add Makefile variables for `make test-coverage` to run successfully
0xDEC0DE
added a commit
to 0xDEC0DE/go-billy
that referenced
this pull request
Apr 24, 2025
a reprise of go-git#104, with added tests Limited the scope of the CreateWithChroot tests to OsFs, because MemFs creates parent directories with bonkers permissions. drive-by: add Makefile variables for `make test-coverage` to run successfully
0xDEC0DE
added a commit
to 0xDEC0DE/go-billy
that referenced
this pull request
Apr 27, 2025
a reprise of go-git#104, with added tests Limited the scope of the CreateWithChroot tests to OsFs, because MemFs creates parent directories with bonkers permissions. drive-by: add Makefile variables for `make test-coverage` to run successfully
0xDEC0DE
added a commit
to 0xDEC0DE/go-billy
that referenced
this pull request
Apr 28, 2025
a reprise of go-git#104, with added tests Limited the scope of the CreateWithChroot tests to OsFs, because MemFs creates parent directories with bonkers permissions. drive-by: add Makefile variables for `make test-coverage` to run successfully
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary to fix go-git/go-git#1371