Skip to content

Option to dismiss a review, dissmiss all reviews in full gitea #15472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 of 6 tasks
engaltori opened this issue Apr 14, 2021 · 0 comments · Fixed by #15477
Closed
1 of 6 tasks

Option to dismiss a review, dissmiss all reviews in full gitea #15472

engaltori opened this issue Apr 14, 2021 · 0 comments · Fixed by #15477
Labels
type/bug
Milestone
1.14.1

Comments

@engaltori
Copy link

engaltori commented Apr 14, 2021 •
edited
Loading

  • Gitea version (or commit ref): 1.14.0
  • Git version: 2.30.2
  • Operating system: Ubuntu 18.04
  • Running Methode: Docker 19.03
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
  • Log (Sorry for the bad formatting):
[36m2021/04/14 12:43:09 �[0m�[32m.../repo/pull_review.go:230:�[32mDismissReview()�[0m �[1;32m[I]�[0m [SQL]�[1m�[0m �[1mUPDATE "review" SET "dismissed" = $1, "updated_unix" = $2 �[0m �[1m[true 1618404189]�[0m - �[1m31.960722ms�[0m

Description

If I dissmiss a review of a pull request, the column "dismissed" in every row of the table "review" is updated with the value "true"
zeripath added a commit to zeripath/gitea that referenced this issue Apr 14, 2021
@zeripath
Ensure review dismissal only dismisses the correct review
833bcf9 
Fix go-gitea#15472

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath mentioned this issue Apr 14, 2021
Merged
@zeripath zeripath added this to the 1.14.1 milestone Apr 14, 2021
zeripath added a commit that referenced this issue Apr 15, 2021
@zeripath
Ensure review dismissal only dismisses the correct review (#15477)
9d07fac 
Fix #15472

Signed-off-by: Andrew Thornton [email protected]
zeripath added a commit to zeripath/gitea that referenced this issue Apr 15, 2021
@zeripath
Ensure review dismissal only dismisses the correct review (go-gitea#1…
45a30e0 
…5477)

Backport go-gitea#15477

Fix go-gitea#15472

Signed-off-by: Andrew Thornton [email protected]
@zeripath zeripath mentioned this issue Apr 15, 2021
Merged
lafriks pushed a commit that referenced this issue Apr 15, 2021
@zeripath @6543
Ensure review dismissal only dismisses the correct review (#15477) (#…
edd4ab4 
…15489)

Backport #15477

Fix #15472

Signed-off-by: Andrew Thornton [email protected]

Co-authored-by: 6543 <[email protected]>
@zeripath zeripath mentioned this issue Apr 19, 2021
Closed
@go-gitea go-gitea locked and limited conversation to collaborators Jun 4, 2021
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this issue Aug 10, 2021
@zeripath @AbdulrhmnGhanem
Ensure review dismissal only dismisses the correct review (go-gitea#1…
e528810 
…5477)

Fix go-gitea#15472

Signed-off-by: Andrew Thornton [email protected]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.14.1
Development

Successfully merging a pull request may close this issue.

Ensure review dismissal only dismisses the correct review zeripath/gitea
2 participants
@zeripath @engaltori