problems with copying CRLF files in the browser

[mrexodia]

• Gitea version (or commit ref): 62f600c
• Git version: ?
• Operating system: Windows 8.1 x64
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant

When copying a file with CRLF line endings (https://try.gitea.io/mrexodia/testcopy/src/master/crlf.txt) there will be additional lines inserted when pasting in notepad:

[silverwind]

This is because of empty text nodes inside the code <pre>:

<ol class="linenums"><li class="L1" rel="L1">Lorem ipsum dolor sit amet
</li>
<li class="L2" rel="L2">Nam condimentum, odio a egestas dapibus
</li>
<li class="L3" rel="L3">Nulla egestas velit nec elit dapibus aliquet.
</li>
<li class="L4" rel="L4">Nulla facilisi. Praesent vel sem sit amet
</li>
<li class="L5" rel="L5">Fusce tincidunt laoreet laoreet.</li>
</ol>

Fix would be to render </li><li (e.g. no newline between)

[mrexodia]

The same issue was fixed in gogs by simply trimming \r from the end of every line: gogs/gogs@91f65ce

[appleboy]

@mrexodia fixed in #1931

[mrexodia]

Yeah, but that's not merged 😄

[silverwind]

Soon. I'd say my approach is the better one, it preserves the original line endings and does not introduce a extra \n at the end of the copied text.

[mrexodia]

From what I can tell no new lines were introduced if I copy from here: https://try.gogs.io/mrexodia/testcopy/src/master/crlf.txt

I'm still looking at switching to gitea, but I couldn't really find a list of benefits or a clear update path from gogs so I'm postponing it...

[silverwind]

Might be your editor trimming it, but I certainly get a newline pasted after the text:

[lafriks]

@mrexodia Upgrade instructions are here - https://docs.gitea.io/en-us/upgrade-from-gogs/