Description
Description
Crash in one of the handlers (regression in 1.16.6):
2022/05/05 02:45:40 Started GET /marado/yarn/compare/master...new_ui?style=unified&whitespace=ignore-all for 216.244.66.235:0
2022/05/05 02:45:40 routers/web/base.go:130:1() [E] PANIC: runtime error: invalid memory address or nil pointer dereference
/usr/local/go/src/runtime/panic.go:220 (0x457635)
/usr/local/go/src/runtime/signal_unix.go:818 (0x457605)
/go/src/code.gitea.io/gitea/models/repo.go:135 (0x138cf96)
/go/src/code.gitea.io/gitea/models/repo.go:131 (0x1ea7944)
/go/src/code.gitea.io/gitea/routers/web/repo/compare.go:448 (0x1ea791a)
/go/src/code.gitea.io/gitea/routers/web/repo/compare.go:683 (0x1ea9c69)
/go/src/code.gitea.io/gitea/modules/web/route.go:74 (0x1e47d44)
/usr/local/go/src/net/http/server.go:2084 (0x7ac6ce)
/go/pkg/mod/github.com/go-chi/chi/[email protected]/mux.go:442 (0x1656dd5)
/usr/local/go/src/net/http/server.go:2084 (0x7ac6ce)
/go/src/code.gitea.io/gitea/modules/web/route.go:113 (0x1e48531)
/usr/local/go/src/net/http/server.go:2084 (0x7ac6ce)
/go/src/code.gitea.io/gitea/modules/web/route.go:113 (0x1e48531)
/usr/local/go/src/net/http/server.go:2084 (0x7ac6ce)
/go/src/code.gitea.io/gitea/modules/web/route.go:113 (0x1e48531)
/usr/local/go/src/net/http/server.go:2084 (0x7ac6ce)
/go/pkg/mod/github.com/go-chi/chi/[email protected]/middleware/get_head.go:37 (0x1e77de4)
/usr/local/go/src/net/http/server.go:2084 (0x7ac6ce)
/go/src/code.gitea.io/gitea/modules/web/route.go:113 (0x1e48531)
/usr/local/go/src/net/http/server.go:2084 (0x7ac6ce)
/go/src/code.gitea.io/gitea/modules/context/context.go:745 (0x1668786)
/usr/local/go/src/net/http/server.go:2084 (0x7ac6ce)
/go/pkg/mod/github.com/go-chi/chi/[email protected]/mux.go:71 (0x1654c0c)
/go/pkg/mod/github.com/go-chi/chi/[email protected]/mux.go:314 (0x16565bb)
/usr/local/go/src/net/http/server.go:2084 (0x7ac6ce)
/go/pkg/mod/github.com/go-chi/chi/[email protected]/mux.go:442 (0x1656dd5)
/usr/local/go/src/net/http/server.go:2084 (0x7ac6ce)
/go/src/code.gitea.io/gitea/routers/web/base.go:169 (0x20332d1)
/usr/local/go/src/net/http/server.go:2084 (0x7ac6ce)
/go/pkg/mod/gitea.com/go-chi/[email protected]/session.go:257 (0x146137d)
/usr/local/go/src/net/http/server.go:2084 (0x7ac6ce)
/go/src/code.gitea.io/gitea/modules/public/public.go:42 (0x15949db)
/usr/local/go/src/net/http/server.go:2084 (0x7ac6ce)
/go/pkg/mod/github.com/go-chi/chi/[email protected]/mux.go:71 (0x1654c0c)
/go/pkg/mod/github.com/go-chi/chi/[email protected]/mux.go:314 (0x16565bb)
/usr/local/go/src/net/http/server.go:2084 (0x7ac6ce)
/go/pkg/mod/github.com/go-chi/chi/[email protected]/mux.go:442 (0x1656dd5)
/usr/local/go/src/net/http/server.go:2084 (0x7ac6ce)
/go/src/code.gitea.io/gitea/routers/common/middleware.go:78 (0x1e7dfc1)
/usr/local/go/src/net/http/server.go:2084 (0x7ac6ce)
/go/src/code.gitea.io/gitea/routers/common/logger.go:23 (0x1e7d24f)
/usr/local/go/src/net/http/server.go:2084 (0x7ac6ce)
/go/pkg/mod/github.com/go-chi/chi/[email protected]/middleware/strip.go:30 (0x1e7ab58)
/usr/local/go/src/net/http/server.go:2084 (0x7ac6ce)
/go/pkg/mod/github.com/chi-middleware/[email protected]/middleware.go:37 (0x1e77456)
/usr/local/go/src/net/http/server.go:2084 (0x7ac6ce)
/go/src/code.gitea.io/gitea/routers/common/middleware.go:31 (0x1e7de19)
/usr/local/go/src/net/http/server.go:2084 (0x7ac6ce)
/go/pkg/mod/github.com/go-chi/chi/[email protected]/mux.go:88 (0x1654bc1)
/go/src/code.gitea.io/gitea/modules/web/route.go:328 (0x1e4b38d)
/usr/local/go/src/net/http/server.go:2916 (0x7afcba)
/usr/local/go/src/net/http/server.go:1966 (0x7ab176)
/usr/local/go/src/runtime/asm_amd64.s:1571 (0x4745a0)
2022/05/05 02:45:40 Completed GET /marado/yarn/compare/master...new_ui?style=unified&whitespace=ignore-all 500 Internal Server Error in 43.252646ms
Gitea Version
1.16.7
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
2022/05/05 02:45:40 Started GET /marado/yarn/compare/master...new_ui?style=unified&whitespace=ignore-all for 216.244.66.235:0 2022/05/05 02:45:40 routers/web/base.go:130:1() [E] PANIC: runtime error: invalid memory address or nil pointer dereference /usr/local/go/src/runtime/panic.go:220 (0x457635) /usr/local/go/src/runtime/signal_unix.go:818 (0x457605) /go/src/code.gitea.io/gitea/models/repo.go:135 (0x138cf96) /go/src/code.gitea.io/gitea/models/repo.go:131 (0x1ea7944) /go/src/code.gitea.io/gitea/routers/web/repo/compare.go:448 (0x1ea791a) /go/src/code.gitea.io/gitea/routers/web/repo/compare.go:683 (0x1ea9c69) /go/src/code.gitea.io/gitea/modules/web/route.go:74 (0x1e47d44) /usr/local/go/src/net/http/server.go:2084 (0x7ac6ce) /go/pkg/mod/github.com/go-chi/chi/[email protected]/mux.go:442 (0x1656dd5) /usr/local/go/src/net/http/server.go:2084 (0x7ac6ce) /go/src/code.gitea.io/gitea/modules/web/route.go:113 (0x1e48531) /usr/local/go/src/net/http/server.go:2084 (0x7ac6ce) /go/src/code.gitea.io/gitea/modules/web/route.go:113 (0x1e48531) /usr/local/go/src/net/http/server.go:2084 (0x7ac6ce) /go/src/code.gitea.io/gitea/modules/web/route.go:113 (0x1e48531) /usr/local/go/src/net/http/server.go:2084 (0x7ac6ce) /go/pkg/mod/github.com/go-chi/chi/[email protected]/middleware/get_head.go:37 (0x1e77de4) /usr/local/go/src/net/http/server.go:2084 (0x7ac6ce) /go/src/code.gitea.io/gitea/modules/web/route.go:113 (0x1e48531) /usr/local/go/src/net/http/server.go:2084 (0x7ac6ce) /go/src/code.gitea.io/gitea/modules/context/context.go:745 (0x1668786) /usr/local/go/src/net/http/server.go:2084 (0x7ac6ce) /go/pkg/mod/github.com/go-chi/chi/[email protected]/mux.go:71 (0x1654c0c) /go/pkg/mod/github.com/go-chi/chi/[email protected]/mux.go:314 (0x16565bb) /usr/local/go/src/net/http/server.go:2084 (0x7ac6ce) /go/pkg/mod/github.com/go-chi/chi/[email protected]/mux.go:442 (0x1656dd5) /usr/local/go/src/net/http/server.go:2084 (0x7ac6ce) /go/src/code.gitea.io/gitea/routers/web/base.go:169 (0x20332d1) /usr/local/go/src/net/http/server.go:2084 (0x7ac6ce) /go/pkg/mod/gitea.com/go-chi/[email protected]/session.go:257 (0x146137d) /usr/local/go/src/net/http/server.go:2084 (0x7ac6ce) /go/src/code.gitea.io/gitea/modules/public/public.go:42 (0x15949db) /usr/local/go/src/net/http/server.go:2084 (0x7ac6ce) /go/pkg/mod/github.com/go-chi/chi/[email protected]/mux.go:71 (0x1654c0c) /go/pkg/mod/github.com/go-chi/chi/[email protected]/mux.go:314 (0x16565bb) /usr/local/go/src/net/http/server.go:2084 (0x7ac6ce) /go/pkg/mod/github.com/go-chi/chi/[email protected]/mux.go:442 (0x1656dd5) /usr/local/go/src/net/http/server.go:2084 (0x7ac6ce) /go/src/code.gitea.io/gitea/routers/common/middleware.go:78 (0x1e7dfc1) /usr/local/go/src/net/http/server.go:2084 (0x7ac6ce) /go/src/code.gitea.io/gitea/routers/common/logger.go:23 (0x1e7d24f) /usr/local/go/src/net/http/server.go:2084 (0x7ac6ce) /go/pkg/mod/github.com/go-chi/chi/[email protected]/middleware/strip.go:30 (0x1e7ab58) /usr/local/go/src/net/http/server.go:2084 (0x7ac6ce) /go/pkg/mod/github.com/chi-middleware/[email protected]/middleware.go:37 (0x1e77456) /usr/local/go/src/net/http/server.go:2084 (0x7ac6ce) /go/src/code.gitea.io/gitea/routers/common/middleware.go:31 (0x1e7de19) /usr/local/go/src/net/http/server.go:2084 (0x7ac6ce) /go/pkg/mod/github.com/go-chi/chi/[email protected]/mux.go:88 (0x1654bc1) /go/src/code.gitea.io/gitea/modules/web/route.go:328 (0x1e4b38d) /usr/local/go/src/net/http/server.go:2916 (0x7afcba) /usr/local/go/src/net/http/server.go:1966 (0x7ab176) /usr/local/go/src/runtime/asm_amd64.s:1571 (0x4745a0) 2022/05/05 02:45:40 Completed GET /marado/yarn/compare/master...new_ui?style=unified&whitespace=ignore-all 500 Internal Server Error in 43.252646ms
Screenshots
No response
Git Version
N/A
Operating System
N/A
How are you running Gitea?
Docker Swarm
Database
SQLite