Skip to content

Add option to edit mirror interval on repo push mirrors #21295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
6543 opened this issue Sep 29, 2022 · 4 comments · Fixed by #26151
Closed

Add option to edit mirror interval on repo push mirrors #21295

6543 opened this issue Sep 29, 2022 · 4 comments · Fixed by #26151
Labels
good first issue Likely to be an easy fix topic/ui Change the appearance of the Gitea UI topic/ui-interaction Change the process how users use Gitea instead of the visual appearance type/enhancement An improvement of existing functionality

Comments

@6543
Copy link
Member

6543 commented Sep 29, 2022

at the moment you have to recreate a push mirror if you want to change the interval :/
@6543 6543 added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI good first issue Likely to be an easy fix topic/ui-interaction Change the process how users use Gitea instead of the visual appearance labels Sep 29, 2022
@CypherpunkSamurai
Copy link
Contributor

Hello @6543,

I would like to contribute to this issue, I've worked on golang projects before, and would like to work on gitea. how can i get started? :)

@the-writer-dev
Copy link

@6543 Could you assign this to me?

@puni9869
Copy link
Member

puni9869 commented Mar 20, 2023 •
edited
Loading

If we are still looking this issue to be fixed. I can take this forward. Please assign me.

@puni9869
Copy link
Member

puni9869 commented Mar 21, 2023 •
edited
Loading

As per my understanding
we have mininum 10 minute default periodic sync time when we setting up any mirror and once we done setting as below
image
screen shot

We don't have option to edit the periodic time in existing setted up push mirror.
image

So in this ticket we want that small feature so that we don't have to recreate the mirror again and again.

@jolheiser

@puni9869 puni9869 removed their assignment Jun 18, 2023
@puni9869 puni9869 mentioned this issue Jul 26, 2023
Merged
delvh pushed a commit that referenced this issue Aug 1, 2023
@puni9869 @wxiaoguang
Allow editing push mirrors after creation (#26151)
ab388de 
Allow users to edit the sync interval for existing push mirrors.
Currently, there is no way to modify the interval once the mirror is
created.
<details>
  <summary>Screenshots</summary>
  
## Before
<img width="936" alt="Screenshot 2023-07-26 at 9 31 21 AM"
src="https://github.com/go-gitea/gitea/assets/80308335/35b8a40c-4320-474c-a866-1dea0f1fa0de">


## After
<img width="945" alt="Screenshot 2023-07-26 at 9 44 40 AM"
src="https://github.com/go-gitea/gitea/assets/80308335/ee12e12f-0f68-4feb-90eb-33366f5997d3">

### On hover

<img width="247" alt="image"
src="https://github.com/go-gitea/gitea/assets/80308335/2f32de45-bd50-4150-9623-3be2ef3ea7f8">
<img width="237" alt="image"
src="https://github.com/go-gitea/gitea/assets/80308335/49f4ab4d-ccff-4489-80ce-a9788a73c3bb">
<img width="245" alt="image"
src="https://github.com/go-gitea/gitea/assets/80308335/165fc888-9d48-438a-b730-d4beb12122af">

### Edit modal
<img width="905" alt="image"
src="https://github.com/go-gitea/gitea/assets/80308335/2a7ca24b-4f36-4e0e-9799-39f2ecc46413">

### Only valid times are allowed
<img width="728" alt="Screenshot 2023-07-26 at 9 50 01 AM"
src="https://github.com/go-gitea/gitea/assets/80308335/ced6d330-c235-4e29-8f17-28daddcf1444">
<img width="853" alt="image"
src="https://github.com/go-gitea/gitea/assets/80308335/8636f62a-70d1-4684-a3e8-b205adc03580">

</details>
Fixes #21295

---------

Co-authored-by: wxiaoguang <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Likely to be an easy fix topic/ui Change the appearance of the Gitea UI topic/ui-interaction Change the process how users use Gitea instead of the visual appearance type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow editing push mirrors after creation puni9869/gitea
4 participants
@6543 @CypherpunkSamurai @puni9869 @the-writer-dev