Go 1.7: {{if}} branches end in different contexts

[strk]

As of commit e08d1fc (current master branch) new installation fails with following error:

html/template:user/dashboard/repo-search:3:13: {{if}} branches end in different contexts: {stateJSRegexp delimNone urlPartNone jsCtxRegexp attrNone elementScript }, {stateJS delimNone urlPartNone jsCtxRegexp attrNone elementScript }

Gitea has been built with go build.
The offending route is the default one (/) which is were you are directed right after install.

[lafriks]

strange, I can't seem to be able to reproduce that. Not in new install, not in existing one. Built with TAGS="sqlite" make build

[strk]

Here I have go version go1.7.4 linux/amd64

The other specificity of my install is that I'm using an existing PostgreSQL database, with a user in it.
When cleaning cookies the error appears after login.

[strk]

I can still reproduce with TAGS="sqlite" make build builds (and sqlite3 database).
In this case I have to register a new user before logging in, and get that error upon first login.

[strk]

The template does indeed look weird, check this snippet:

        <div v-if="tab === 'repos'" class="ui tab active list">

What's that v-if ??

[daviian]

@strk It's from Vue.js. Do you use Chrome? Chrome has an intriguing caching now. Open your public/index.js in a seperate tab and reload. Maybe you have an old js file.

[strk]

Ok, anyway the problem is somewhere in here, at the top of templates/user/dashboard/repo-search.tmpl:

        {{if not .ContextUser.IsOrganization}}
        <div class="ui two item stackable tabable menu">
            <a :class="{item: true, active: tab === 'repos'}" @click="changeTab('repos')">{{.i18n.Tr "repository"}}</a>
            <a :class="{item: true, active: tab === 'orgs'}" @click="changeTab('orgs')">{{.i18n.Tr "organization"}}</a>
        </div>
        {{end}}

Removing the portion inside the condition, leaving the following, fixes it:

        {{if not .ContextUser.IsOrganization}}
        {{end}}

[daviian]

I can't reproduce that error as well. I am on latest master. My Go version is 1.8.3

[strk]

What Go version are you using ? What else could be different ?

[daviian]

As I said, Go version is 1.8.3
Have you tried hard resetting your git repository to remove old folders etc.? Just an idea.

[strk]

@lafriks are you also using Go 1.8 ? Both: any chance you can try an older version ?
I'll repeat the steps to reproduce:

1. Install Gitea (tried both PostgreSQL and Sqlite3 backends)
2. Register new account (will become admin)
3. Login as the new account

[daviian]

@strk I will try with an older version, give me a moment.

[daviian]

Ok I can confirm this issue with Go 1.7.4!

[strk]

Thanks for testing ! Should this be filed upstream to Vue ? (or can you tell where else the bug is ?)