500 error on pulls page (related to dismissed review comment)

[jpraet]

Description

I'm not sure exactly sure what caused this, but we are getting a HTTP 500 error on a certain pull request.

2023/09/27 08:48:58 ...eb/routing/logger.go:78:func1() [W] router: failed    GET /CBSS/rmsf/pulls/116 for 172.19.0.2:56762, panic in 52.2ms @ repo/issue.go:1267(repo.ViewIssue), err=runtime error: invalid memory address or nil pointer dereference
2023/09/27 08:48:58 ...rs/common/errpage.go:25:RenderPanicErrorPage() [E] PANIC: runtime error: invalid memory address or nil pointer dereference
/usr/local/go/src/runtime/panic.go:884 (0x449832)
/go/src/code.gitea.io/gitea/modules/web/routing/logger_manager.go:116 (0x2328044)
/usr/local/go/src/runtime/panic.go:884 (0x449832)
/usr/local/go/src/runtime/panic.go:260 (0x46123c)
/usr/local/go/src/runtime/signal_unix.go:841 (0x46120c)
/go/src/code.gitea.io/gitea/models/issues/review.go:158 (0x14cf9f3)
/go/src/code.gitea.io/gitea/models/issues/comment_list.go:460 (0x14cfa07)
/go/src/code.gitea.io/gitea/models/issues/comment_list.go:494 (0x14cfd26)
/go/src/code.gitea.io/gitea/models/issues/issue.go:358 (0x14d4651)
/go/src/code.gitea.io/gitea/routers/web/repo/issue.go:1340 (0x2620f6e)

It has something to do with dismissed reviews, I believe comment.Review is nil here:

gitea/models/issues/comment_list.go

Lines 459 to 460 in e502be4

	if comment.Type == CommentTypeDismissReview {
	if err := comment.Review.LoadReviewer(ctx); err != nil {

Gitea Version

1.20.4

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

docker

Database

PostgreSQL

[CaiCandong]

How to reproduce ?

[jpraet]

As the PR page gives a HTTP 500 I cannot easily see which actions happened in the history of this PR.
So unfortunately I don't know the exact steps to reproduce.