Skip to content

Old Scheduled Action Tasks Not Cleared When Creating Remove Scheduled Task Configuration Commits #27650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ExplodingDragon opened this issue Oct 16, 2023 · 0 comments · Fixed by #27662
Closed

Old Scheduled Action Tasks Not Cleared When Creating Remove Scheduled Task Configuration Commits #27650

ExplodingDragon opened this issue Oct 16, 2023 · 0 comments · Fixed by #27662
Labels
type/bug
Milestone
1.21.0

Comments

@ExplodingDragon
Copy link
Contributor

Description

After I remove the existing cron configuration, gitea does not remove the scheduled tasks from the database,

image

Configuration parsing fails and ends without clearing the old cron task.

image

gitea/services/actions/notifier_helper.go

Lines 149 to 152 in 0d55f64

workflows, schedules, err := actions_module.DetectWorkflows(gitRepo, commit, input.Event, input.Payload)
if err != nil {
return fmt.Errorf("DetectWorkflows: %w", err)
}

Gitea Version

main

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

systemd

Database

SQLite
@ExplodingDragon ExplodingDragon changed the title Old Scheduled Tasks Not Cleared When Creating Remove Scheduled Task Configuration Commits Old Scheduled Action Tasks Not Cleared When Creating Remove Scheduled Task Configuration Commits Oct 16, 2023
@lunny lunny added this to the 1.21.0 milestone Oct 17, 2023
@KN4CK3R KN4CK3R mentioned this issue Oct 17, 2023
Merged
lunny pushed a commit that referenced this issue Oct 18, 2023
@KN4CK3R
Always delete existing scheduled action tasks (#27662)
83186ec 
Fixes #27650
@GiteaBot GiteaBot mentioned this issue Oct 19, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Oct 19, 2023
@KN4CK3R @GiteaBot
Always delete existing scheduled action tasks (go-gitea#27662)
708ec9c 
Fixes go-gitea#27650
KN4CK3R added a commit that referenced this issue Oct 19, 2023
@GiteaBot @KN4CK3R
Always delete existing scheduled action tasks (#27662) (#27688)
9b14f1a 
Backport #27662 by @KN4CK3R

Fixes #27650

Co-authored-by: KN4CK3R <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2023
silverwind pushed a commit to silverwind/gitea that referenced this issue Feb 20, 2024
@KN4CK3R @silverwind
Always delete existing scheduled action tasks (go-gitea#27662)
64086f8 
Fixes go-gitea#27650
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.21.0
Development

Successfully merging a pull request may close this issue.

Always delete existing scheduled action tasks KN4CK3R/gitea
2 participants
@lunny @ExplodingDragon