schedule action task not work

[yp05327]

Description

reported from qq group.

in 1.21.5, schedule action task does not work when the cron is:

There is the actions task list:

At first, we set the task to run every minitues, and it worked as the action task #75.

Then we changed it to "0 0 * * *", and we can see the action task #76 for this change about 20 hours before.

But the schedule action task didn't run in about 20 hours.
We check the timezone, it is correct.

Gitea Version

1.21.5

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

other user's instance

Database

None

[yp05327]

There's a bug in actions notifier, but don't know whether it is related to this issue.

[yp05327]

The details of this bug:
I think it comes from #27662.
After this PR, handleSchedules will always delete existing scheduled tasks, and if schedules(which names detectedWorkflows in handleSchedules) is empty, it will return nil.
This may causes a bug, when user forked the repo for creating a PR, detectSchedule is false, so schedules is empty.
Then in handleSchedules, we will delete all existing scheduled tasks in the original repo, and then return.

Not sure whether other cases when detectSchedule is false, will also cause unexcepted deletion of existing scheduled tasks.

[jameshurst]

I've been noticing this on 1.21.5 as well. It seems like scheduled actions stop working after a pull request gets merged.

[github-actions]

Automatically locked because of our CONTRIBUTING guidelines